On Tue, Apr 26 2022 at 10:33, Jason A. Donenfeld wrote:
Subject: x86/tsc: Use .....
This has absolutely nothing to do with ASM and the sentence after the
colon starts with an uppercase letter.
> In the event that random_get_entropy() can't access a cycle counter or
> similar, falling back to returning 0 is suboptimal. Instead, fallback
> to calling random_get_entropy_fallback(), which isn't extremely high
> precision or guaranteed to be entropic, but is certainly better than
> returning zero all the time.
>
> If CONFIG_X86_TSC=n, then it's possible for the kernel to run on systems
> without RDTSC, such as 486 and certain 586, so the fallback code is only
> required for that case.
>
> As well, fix up both the new function and the get_cycles() function from
> which it was derived to use cpu_feature_enabled() rather than
> boot_cpu_has(), and use !IS_ENABLED() instead of #ifndef.
>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Cc: [email protected]
Same comments vs. Cc's
> Signed-off-by: Jason A. Donenfeld <[email protected]>
> ---
> Changes v6->v7:
> - Adjust commit subject and body to match tip commit style.
Mostly ... :)
With that fixed:
Reviewed-by: Thomas Gleixner <[email protected]>