2021-10-27 21:44:03

by CGEL

Subject: [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c

From: ran jianping <[email protected]>

'linux/io.h' included in 'drivers/platform/x86/barco-p50-gpio.c'
is duplicated.It is also included on the 17 line.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ran jianping <[email protected]>
---
drivers/platform/x86/barco-p50-gpio.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
index f5c72e33f9ae..bb8ed8e95225 100644
--- a/drivers/platform/x86/barco-p50-gpio.c
+++ b/drivers/platform/x86/barco-p50-gpio.c
@@ -14,7 +14,6 @@
#include <linux/delay.h>
#include <linux/dmi.h>
#include <linux/err.h>
-#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/module.h>
--
2.25.1

2021-10-27 21:46:30

by Peter Korsgaard

Subject: Re: [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c

>>>>> "cgel" == cgel zte <[email protected]> writes:

> From: ran jianping <[email protected]>
> 'linux/io.h' included in 'drivers/platform/x86/barco-p50-gpio.c'
> is duplicated.It is also included on the 17 line.

> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ran jianping <[email protected]>
> ---
> drivers/platform/x86/barco-p50-gpio.c | 1 -
> 1 file changed, 1 deletion(-)

> diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
> index f5c72e33f9ae..bb8ed8e95225 100644
> --- a/drivers/platform/x86/barco-p50-gpio.c
> +++ b/drivers/platform/x86/barco-p50-gpio.c
> @@ -14,7 +14,6 @@
> #include <linux/delay.h>
> #include <linux/dmi.h>
> #include <linux/err.h>
> -#include <linux/io.h>

It probably makes more sense to drop the include from line 17 to keep
alphabetical ordering, but otherwise it looks good to.

With that fixed:

Acked-by: Peter Korsgaard <[email protected]>

--
Bye, Peter Korsgaard