If the i2c-parent bus driver is not loaded, returning
-EINVAL will force people to unload and then reload the
module again to get it working.
Signed-off-by: Ionut Nicu <[email protected]>
---
drivers/i2c/muxes/i2c-mux-gpio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index 5d4a99b..eb99f04 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -79,7 +79,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
adapter = of_find_i2c_adapter_by_node(adapter_np);
if (!adapter) {
dev_err(&pdev->dev, "Cannot find parent bus\n");
- return -ENODEV;
+ return -EPROBE_DEFER;
}
mux->data.parent = i2c_adapter_id(adapter);
put_device(&adapter->dev);
--
1.7.1
>>>>> "IN" == Ionut Nicu <[email protected]> writes:
IN> If the i2c-parent bus driver is not loaded, returning
IN> -EINVAL will force people to unload and then reload the
IN> module again to get it working.
IN> Signed-off-by: Ionut Nicu <[email protected]>
Acked-by: Peter Korsgaard <[email protected]>
--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>
On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
> If the i2c-parent bus driver is not loaded, returning
> -EINVAL will force people to unload and then reload the
> module again to get it working.
>
> Signed-off-by: Ionut Nicu <[email protected]>
Doesn't the non-DT case need fixing, too?
> ---
> drivers/i2c/muxes/i2c-mux-gpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index 5d4a99b..eb99f04 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -79,7 +79,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
> adapter = of_find_i2c_adapter_by_node(adapter_np);
> if (!adapter) {
> dev_err(&pdev->dev, "Cannot find parent bus\n");
> - return -ENODEV;
> + return -EPROBE_DEFER;
> }
> mux->data.parent = i2c_adapter_id(adapter);
> put_device(&adapter->dev);
> --
> 1.7.1
>>>>> "WS" == Wolfram Sang <[email protected]> writes:
WS> On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
>> If the i2c-parent bus driver is not loaded, returning
>> -EINVAL will force people to unload and then reload the
>> module again to get it working.
>>
>> Signed-off-by: Ionut Nicu <[email protected]>
WS> Doesn't the non-DT case need fixing, too?
Arguably yes.
--
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>
On 09.10.2013 08:14, ext Peter Korsgaard wrote:
>>>>>> "WS" == Wolfram Sang <[email protected]> writes:
>
> WS> On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
>>> If the i2c-parent bus driver is not loaded, returning
>>> -EINVAL will force people to unload and then reload the
>>> module again to get it working.
>>>
>>> Signed-off-by: Ionut Nicu <[email protected]>
>
> WS> Doesn't the non-DT case need fixing, too?
>
> Arguably yes.
>
Yes, and it's also a one line fix. Should I do it in a separate
patch or should I change this one and resubmit?
> > WS> Doesn't the non-DT case need fixing, too?
> >
> > Arguably yes.
>
> Yes, and it's also a one line fix. Should I do it in a separate
> patch or should I change this one and resubmit?
Resubmit please.