2009-06-01 08:09:34

by Andi Kleen

Subject: Re: [patch 2/2] keep on ticking if oprofile is active

Martin Schwidefsky <[email protected]> writes:

> From: Martin Schwidefsky <[email protected]>
>
> On a NOHZ system with oprofile enabled the timer tick should not be

The old style profile=... profiler should do that too.

-Andi
--
[email protected] -- Speaking for myself only.

2009-06-01 10:22:46

by Martin Schwidefsky

Subject: Re: [patch 2/2] keep on ticking if oprofile is active

On Mon, 01 Jun 2009 10:09:27 +0200
Andi Kleen <[email protected]> wrote:

> Martin Schwidefsky <[email protected]> writes:
>
> > From: Martin Schwidefsky <[email protected]>
> >
> > On a NOHZ system with oprofile enabled the timer tick should not be
>
> The old style profile=... profiler should do that too.

Technically the old style profiler and NOHZ can be combined (see patch
#1 plus a fix as discussed with Thomas). On the other hand it would make
the code simpler if we just fallback to the standard tick if profile= is
used. My personal preference would be to use my patch.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.