2024-03-06 14:22:46

by Arnd Bergmann

[permalink] [raw]
Subject: [v2 PATCH 0/3] arch: mm, vdso: consolidate PAGE_SIZE definition

From: Arnd Bergmann <[email protected]>

Naresh noticed that the newly added usage of the PAGE_SIZE macro in
include/vdso/datapage.h introduced a build regression. I had an older
patch that I revived to have this defined through Kconfig rather than
through including asm/page.h, which is not allowed in vdso code.

The vdso patch series now has a temporary workaround, but I still want to
get this into v6.9 so we can place the hack with CONFIG_PAGE_SIZE
in the vdso.

I've applied this to the asm-generic tree already, please let me know if
there are still remaining issues. It's really close to the merge window
already, so I'd probably give this a few more days before I send a pull
request, or defer it to v6.10 if anything goes wrong.

Sorry for the delay, I was still waiting to resolve the m68k question,
but there were no further replies in the end, so I kept my original
version.

Changes from v1:

- improve Kconfig help texts
- remove an extraneous line in hexagon

Arnd

Link: https://lore.kernel.org/lkml/CA+G9fYtrXXm_KO9fNPz3XaRxHV7UD_yQp-TEuPQrNRHU+_0W_Q@mail.gmail.com/
Link: https://lore.kernel.org/all/[email protected]/
Link: https://lore.kernel.org/lkml/[email protected]/

Arnd Bergmann (3):
arch: consolidate existing CONFIG_PAGE_SIZE_*KB definitions
arch: simplify architecture specific page size configuration
arch: define CONFIG_PAGE_SIZE_*KB on all architectures

arch/Kconfig | 92 +++++++++++++++++++++++++++++-
arch/alpha/Kconfig | 1 +
arch/alpha/include/asm/page.h | 2 +-
arch/arc/Kconfig | 3 +
arch/arc/include/uapi/asm/page.h | 6 +-
arch/arm/Kconfig | 1 +
arch/arm/include/asm/page.h | 2 +-
arch/arm64/Kconfig | 29 +++++-----
arch/arm64/include/asm/page-def.h | 2 +-
arch/csky/Kconfig | 1 +
arch/csky/include/asm/page.h | 2 +-
arch/hexagon/Kconfig | 24 ++------
arch/hexagon/include/asm/page.h | 6 +-
arch/loongarch/Kconfig | 21 ++-----
arch/loongarch/include/asm/page.h | 10 +---
arch/m68k/Kconfig | 3 +
arch/m68k/Kconfig.cpu | 2 +
arch/m68k/include/asm/page.h | 6 +-
arch/microblaze/Kconfig | 1 +
arch/microblaze/include/asm/page.h | 2 +-
arch/mips/Kconfig | 58 ++-----------------
arch/mips/include/asm/page.h | 16 +-----
arch/nios2/Kconfig | 1 +
arch/nios2/include/asm/page.h | 2 +-
arch/openrisc/Kconfig | 1 +
arch/openrisc/include/asm/page.h | 2 +-
arch/parisc/Kconfig | 3 +
arch/parisc/include/asm/page.h | 10 +---
arch/powerpc/Kconfig | 31 ++--------
arch/powerpc/include/asm/page.h | 2 +-
arch/riscv/Kconfig | 1 +
arch/riscv/include/asm/page.h | 2 +-
arch/s390/Kconfig | 1 +
arch/s390/include/asm/page.h | 2 +-
arch/sh/include/asm/page.h | 13 +----
arch/sh/mm/Kconfig | 42 ++++----------
arch/sparc/Kconfig | 2 +
arch/sparc/include/asm/page_32.h | 2 +-
arch/sparc/include/asm/page_64.h | 3 +-
arch/um/Kconfig | 1 +
arch/um/include/asm/page.h | 2 +-
arch/x86/Kconfig | 1 +
arch/x86/include/asm/page_types.h | 2 +-
arch/xtensa/Kconfig | 1 +
arch/xtensa/include/asm/page.h | 2 +-
scripts/gdb/linux/constants.py.in | 2 +-
scripts/gdb/linux/mm.py | 2 +-
47 files changed, 185 insertions(+), 238 deletions(-)

--
2.39.2

To: Thomas Gleixner <[email protected]>
To: Vincenzo Frascino <[email protected]>
To: Kees Cook <[email protected]>
To: Anna-Maria Behnsen <[email protected]>
Cc: Matt Turner <[email protected]>
Cc: Vineet Gupta <[email protected]>
Cc: Russell King <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Guo Ren <[email protected]>
Cc: Brian Cain <[email protected]>
Cc: Huacai Chen <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Thomas Bogendoerfer <[email protected]>
Cc: Helge Deller <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: Christophe Leroy <[email protected]>
Cc: Palmer Dabbelt <[email protected]>
Cc: John Paul Adrian Glaubitz <[email protected]>
Cc: Andreas Larsson <[email protected]>
Cc: Richard Weinberger <[email protected]>
Cc: [email protected]
Cc: Max Filippov <[email protected]>
Cc: Andy Lutomirski <[email protected]>
Cc: Vincenzo Frascino <[email protected]>
Cc: Jan Kiszka <[email protected]>
Cc: Kieran Bingham <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]


2024-03-06 17:18:12

by Thomas Gleixner

[permalink] [raw]
Subject: Re: [v2 PATCH 0/3] arch: mm, vdso: consolidate PAGE_SIZE definition

On Wed, Mar 06 2024 at 15:14, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Naresh noticed that the newly added usage of the PAGE_SIZE macro in
> include/vdso/datapage.h introduced a build regression. I had an older
> patch that I revived to have this defined through Kconfig rather than
> through including asm/page.h, which is not allowed in vdso code.
>
> The vdso patch series now has a temporary workaround, but I still want to
> get this into v6.9 so we can place the hack with CONFIG_PAGE_SIZE
> in the vdso.

Thank you for cleaning this up!

tglx

2024-03-08 16:29:22

by Vincenzo Frascino

[permalink] [raw]
Subject: Re: [v2 PATCH 0/3] arch: mm, vdso: consolidate PAGE_SIZE definition



On 06/03/2024 14:14, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Naresh noticed that the newly added usage of the PAGE_SIZE macro in
> include/vdso/datapage.h introduced a build regression. I had an older
> patch that I revived to have this defined through Kconfig rather than
> through including asm/page.h, which is not allowed in vdso code.
>
> The vdso patch series now has a temporary workaround, but I still want to
> get this into v6.9 so we can place the hack with CONFIG_PAGE_SIZE
> in the vdso.
>
> I've applied this to the asm-generic tree already, please let me know if
> there are still remaining issues. It's really close to the merge window
> already, so I'd probably give this a few more days before I send a pull
> request, or defer it to v6.10 if anything goes wrong.
>
> Sorry for the delay, I was still waiting to resolve the m68k question,
> but there were no further replies in the end, so I kept my original
> version.
>
> Changes from v1:
>
> - improve Kconfig help texts
> - remove an extraneous line in hexagon
>
> Arnd
>

Thanks Arnd, looks good to me.

Reviewed-by: Vincenzo Frascino <[email protected]>