2023-10-06 11:27:18

by Amos Wenger

[permalink] [raw]
Subject: [PATCH] mm/memory-hotplug: fix typo in documentation

I'm 90% sure memory hotunplugging doesn't involve a "fist" phase

Signed-off-by: Amos Wenger <[email protected]>
---
Documentation/admin-guide/mm/memory-hotplug.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/mm/memory-hotplug.rst b/Documentation/admin-guide/mm/memory-hotplug.rst
index cfe034cf1e87..fbf2c22f890d 100644
--- a/Documentation/admin-guide/mm/memory-hotplug.rst
+++ b/Documentation/admin-guide/mm/memory-hotplug.rst
@@ -75,7 +75,7 @@ Memory hotunplug consists of two phases:
(1) Offlining memory blocks
(2) Removing the memory from Linux

-In the fist phase, memory is "hidden" from the page allocator again, for
+In the first phase, memory is "hidden" from the page allocator again, for
example, by migrating busy memory to other memory locations and removing all
relevant free pages from the page allocator After this phase, the memory is no
longer visible in memory statistics of the system.
--
2.39.2


2023-10-06 11:47:55

by David Hildenbrand

[permalink] [raw]
Subject: Re: [PATCH] mm/memory-hotplug: fix typo in documentation

On 06.10.23 13:26, Amos Wenger wrote:
> I'm 90% sure memory hotunplugging doesn't involve a "fist" phase

:D Thanks!

Reviewed-by: David Hildenbrand <[email protected]>

>
> Signed-off-by: Amos Wenger <[email protected]>
> ---
> Documentation/admin-guide/mm/memory-hotplug.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/mm/memory-hotplug.rst b/Documentation/admin-guide/mm/memory-hotplug.rst
> index cfe034cf1e87..fbf2c22f890d 100644
> --- a/Documentation/admin-guide/mm/memory-hotplug.rst
> +++ b/Documentation/admin-guide/mm/memory-hotplug.rst
> @@ -75,7 +75,7 @@ Memory hotunplug consists of two phases:
> (1) Offlining memory blocks
> (2) Removing the memory from Linux
>
> -In the fist phase, memory is "hidden" from the page allocator again, for
> +In the first phase, memory is "hidden" from the page allocator again, for
> example, by migrating busy memory to other memory locations and removing all
> relevant free pages from the page allocator After this phase, the memory is no
> longer visible in memory statistics of the system.

--
Cheers,

David / dhildenb

2023-10-10 19:12:32

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] mm/memory-hotplug: fix typo in documentation

Amos Wenger <[email protected]> writes:

> I'm 90% sure memory hotunplugging doesn't involve a "fist" phase
>
> Signed-off-by: Amos Wenger <[email protected]>
> ---
> Documentation/admin-guide/mm/memory-hotplug.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Depends on how hard it is to get out, perhaps :)

Applied, thanks.

jon