2023-10-02 21:18:33

by Thomas Gleixner

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] irqchip/qcom-pdc: Add support for v3.2 HW

On Tue, Sep 05 2023 at 15:19, Neil Armstrong wrote:
> Starting from HW version 3.2 the IRQ_ENABLE bit has moved to the
> IRQ_i_CFG register and requires a change of the driver to avoid
> writing into an undefined register address.
>
> Get the HW version from registers and set the IRQ_ENABLE bit to the
> correct register depending on the HW version.
>
> Signed-off-by: Dmitry Baryshkov <[email protected]>
> Reviewed-by: Maulik Shah <[email protected]>
> Signed-off-by: Neil Armstrong <[email protected]>

This S-O-B chain is broken. Who is the real author of that?

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Thanks,

tglx