2022-11-11 08:31:43

by Bo Liu

Subject: [PATCH] fat (exportfs): Fix some kernel-doc warnings

Fixes the following W=1 kernel build warning(s):
fs/fat/nfs.c:21: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
fs/fat/nfs.c:139: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Signed-off-by: Bo Liu <[email protected]>
---
fs/fat/nfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fat/nfs.c b/fs/fat/nfs.c
index af191371c352..3626eb585a98 100644
--- a/fs/fat/nfs.c
+++ b/fs/fat/nfs.c
@@ -17,7 +17,7 @@ struct fat_fid {
#define FAT_FID_SIZE_WITHOUT_PARENT 3
#define FAT_FID_SIZE_WITH_PARENT (sizeof(struct fat_fid)/sizeof(u32))

-/**
+/*
* Look up a directory inode given its starting cluster.
*/
static struct inode *fat_dget(struct super_block *sb, int i_logstart)
@@ -135,7 +135,7 @@ fat_encode_fh_nostale(struct inode *inode, __u32 *fh, int *lenp,
return type;
}

-/**
+/*
* Map a NFS file handle to a corresponding dentry.
* The dentry may or may not be connected to the filesystem root.
*/
--
2.27.0

2022-11-11 11:37:04

by OGAWA Hirofumi

Subject: Re: [PATCH] fat (exportfs): Fix some kernel-doc warnings

Bo Liu <[email protected]> writes:

> Fixes the following W=1 kernel build warning(s):
> fs/fat/nfs.c:21: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> fs/fat/nfs.c:139: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Bo Liu <[email protected]>

Looks good.

Acked-by: OGAWA Hirofumi <[email protected]>

> ---
> fs/fat/nfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/nfs.c b/fs/fat/nfs.c
> index af191371c352..3626eb585a98 100644
> --- a/fs/fat/nfs.c
> +++ b/fs/fat/nfs.c
> @@ -17,7 +17,7 @@ struct fat_fid {
> #define FAT_FID_SIZE_WITHOUT_PARENT 3
> #define FAT_FID_SIZE_WITH_PARENT (sizeof(struct fat_fid)/sizeof(u32))
>
> -/**
> +/*
> * Look up a directory inode given its starting cluster.
> */
> static struct inode *fat_dget(struct super_block *sb, int i_logstart)
> @@ -135,7 +135,7 @@ fat_encode_fh_nostale(struct inode *inode, __u32 *fh, int *lenp,
> return type;
> }
>
> -/**
> +/*
> * Map a NFS file handle to a corresponding dentry.
> * The dentry may or may not be connected to the filesystem root.
> */

--
OGAWA Hirofumi <[email protected]>