2022-03-23 23:34:39

by Thomas Gleixner

Subject: Re: ping Re: [PATCH v4 0/2] x86: Fix ARCH_REQ_XCOMP_PERM and update the test

On Wed, Mar 23 2022 at 15:24, Paolo Bonzini wrote:
> On 3/23/22 13:55, Thomas Gleixner wrote:
>> --- a/arch/x86/kernel/fpu/xstate.c
>> +++ b/arch/x86/kernel/fpu/xstate.c
>> @@ -1625,6 +1625,8 @@ static int __xstate_request_perm(u64 per
>>
>> /* Calculate the resulting kernel state size */
>> mask = permitted | requested;
>> + /* Take supervisor states into account */
>> + mask |= xfeatures_mask_supervisor();
>> ksize = xstate_calculate_size(mask, compacted);
>>
>
> This should be only added in for the !guest case.

Yes, I figured that out already :)

2022-03-25 19:53:12

by Thomas Gleixner

Subject: Re: ping Re: [PATCH v4 0/2] x86: Fix ARCH_REQ_XCOMP_PERM and update the test

On Wed, Mar 23 2022 at 18:07, Thomas Gleixner wrote:
> On Wed, Mar 23 2022 at 15:24, Paolo Bonzini wrote:
>> On 3/23/22 13:55, Thomas Gleixner wrote:
>>> --- a/arch/x86/kernel/fpu/xstate.c
>>> +++ b/arch/x86/kernel/fpu/xstate.c
>>> @@ -1625,6 +1625,8 @@ static int __xstate_request_perm(u64 per
>>>
>>> /* Calculate the resulting kernel state size */
>>> mask = permitted | requested;
>>> + /* Take supervisor states into account */
>>> + mask |= xfeatures_mask_supervisor();
>>> ksize = xstate_calculate_size(mask, compacted);
>>>
>>
>> This should be only added in for the !guest case.
>
> Yes, I figured that out already :)

Hrm, that has more consequences vs. the buffer conversion functions. Let
me stare some more.

Thanks,

tglx