2021-11-26 03:54:11

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the tip tree

Hi all,

After merging the tip tree, today's linux-next build (sparc defconfig)
failed like this:

In file included from arch/sparc/include/asm/futex_32.h:4:0,
from arch/sparc/include/asm/futex.h:7,
from kernel/futex/futex.h:12,
from kernel/futex/core.c:41:
kernel/futex/core.c: In function 'futex_cmpxchg_value_locked':
include/asm-generic/futex.h:17:2: error: implicit declaration of function 'futex_atomic_cmpxchg_inatomic_local_generic'; did you mean 'futex_atomic_cmpxchg_inatomic_local'? [-Werror=implicit-function-declaration]
futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
^
include/asm-generic/futex.h:17:2: note: in definition of macro 'futex_atomic_cmpxchg_inatomic'
futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

3f2bedabb62c ("futex: Ensure futex_atomic_cmpxchg_inatomic() is present")

Gcc version (if it matters):
sparc64-linux-gcc (Custom f51944395b6aa154) 7.3.1 20180130

I have reverted that commit for today (and the following one).

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (488.00 B)
OpenPGP digital signature

2021-11-26 10:04:12

by Arnd Bergmann

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the tip tree

On Fri, Nov 26, 2021 at 4:52 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the tip tree, today's linux-next build (sparc defconfig)
> failed like this:
>
> In file included from arch/sparc/include/asm/futex_32.h:4:0,
> from arch/sparc/include/asm/futex.h:7,
> from kernel/futex/futex.h:12,
> from kernel/futex/core.c:41:
> kernel/futex/core.c: In function 'futex_cmpxchg_value_locked':
> include/asm-generic/futex.h:17:2: error: implicit declaration of function 'futex_atomic_cmpxchg_inatomic_local_generic'; did you mean 'futex_atomic_cmpxchg_inatomic_local'? [-Werror=implicit-function-declaration]
> futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
> ^
> include/asm-generic/futex.h:17:2: note: in definition of macro 'futex_atomic_cmpxchg_inatomic'
> futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks a lot for the report, I sent a fix now:

https://lore.kernel.org/lkml/[email protected]

Arnd

2021-12-01 22:06:08

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the tip tree

Hi all,

On Fri, 26 Nov 2021 11:01:52 +0100 Arnd Bergmann <[email protected]> wrote:
>
> On Fri, Nov 26, 2021 at 4:52 AM Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the tip tree, today's linux-next build (sparc defconfig)
> > failed like this:
> >
> > In file included from arch/sparc/include/asm/futex_32.h:4:0,
> > from arch/sparc/include/asm/futex.h:7,
> > from kernel/futex/futex.h:12,
> > from kernel/futex/core.c:41:
> > kernel/futex/core.c: In function 'futex_cmpxchg_value_locked':
> > include/asm-generic/futex.h:17:2: error: implicit declaration of function 'futex_atomic_cmpxchg_inatomic_local_generic'; did you mean 'futex_atomic_cmpxchg_inatomic_local'? [-Werror=implicit-function-declaration]
> > futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
> > ^
> > include/asm-generic/futex.h:17:2: note: in definition of macro 'futex_atomic_cmpxchg_inatomic'
> > futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Thanks a lot for the report, I sent a fix now:
>
> https://lore.kernel.org/lkml/[email protected]

I am still getting this failure (Arnd's fix has not been applied).

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (488.00 B)
OpenPGP digital signature

2021-12-01 22:18:22

by Thomas Gleixner

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the tip tree

On Thu, Dec 02 2021 at 09:05, Stephen Rothwell wrote:
> On Fri, 26 Nov 2021 11:01:52 +0100 Arnd Bergmann <[email protected]> wrote:
>>
>> Thanks a lot for the report, I sent a fix now:
>>
>> https://lore.kernel.org/lkml/[email protected]
>
> I am still getting this failure (Arnd's fix has not been applied).

It got applied, but due to tip maintainer confusion the next branch was
not updated. Will be fixed tomorrow.

Thanks,

tglx

2021-12-01 22:19:48

by Thomas Gleixner

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the tip tree

On Wed, Dec 01 2021 at 23:17, Thomas Gleixner wrote:

> On Thu, Dec 02 2021 at 09:05, Stephen Rothwell wrote:
>> On Fri, 26 Nov 2021 11:01:52 +0100 Arnd Bergmann <[email protected]> wrote:
>>>
>>> Thanks a lot for the report, I sent a fix now:
>>>
>>> https://lore.kernel.org/lkml/[email protected]
>>
>> I am still getting this failure (Arnd's fix has not been applied).
>
> It got applied, but due to tip maintainer confusion the next branch was
> not updated. Will be fixed tomorrow.

Actually now. So still today here :)

2021-12-01 22:32:04

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the tip tree

Hi Thomas,

On Wed, 01 Dec 2021 23:19:40 +0100 Thomas Gleixner <[email protected]> wrote:
>
> On Wed, Dec 01 2021 at 23:17, Thomas Gleixner wrote:
>
> > On Thu, Dec 02 2021 at 09:05, Stephen Rothwell wrote:
> >> On Fri, 26 Nov 2021 11:01:52 +0100 Arnd Bergmann <[email protected]> wrote:
> >>>
> >>> Thanks a lot for the report, I sent a fix now:
> >>>
> >>> https://lore.kernel.org/lkml/[email protected]
> >>
> >> I am still getting this failure (Arnd's fix has not been applied).
> >
> > It got applied, but due to tip maintainer confusion the next branch was
> > not updated. Will be fixed tomorrow.
>
> Actually now. So still today here :)

Thanks, I have that now, so it will go into today's linux-next.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (488.00 B)
OpenPGP digital signature