2019-01-08 19:14:50

by Nathan Chancellor

Subject: Clang warning in drivers/gpu/drm/i915/i915_debugfs.c

Hi all,

Commit e845f099f1c6 ("drm/i915/dsc: Add Per connector debugfs node for
DSC support/enable") causes a Clang warning:

drivers/gpu/drm/i915/i915_debugfs.c:4961:17: warning: address of array 'intel_dp->dsc_dpcd' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (intel_dp->dsc_dpcd)
~~ ~~~~~~~~~~^~~~~~~~
1 warning generated.

Did you mean to dereference it or should that print statement just
always show? I normally would send a patch myself but since I'm not
familiar with this code, I'd rather not shoot in the dark :) especially
since it's for a trivial logging statement.

Thanks,
Nathan

2019-01-15 10:56:26

by Jani Nikula

Subject: Re: Clang warning in drivers/gpu/drm/i915/i915_debugfs.c

On Tue, 08 Jan 2019, Nathan Chancellor <[email protected]> wrote:
> Hi all,
>
> Commit e845f099f1c6 ("drm/i915/dsc: Add Per connector debugfs node for
> DSC support/enable") causes a Clang warning:
>
> drivers/gpu/drm/i915/i915_debugfs.c:4961:17: warning: address of array 'intel_dp->dsc_dpcd' will always evaluate to 'true' [-Wpointer-bool-conversion]
> if (intel_dp->dsc_dpcd)
> ~~ ~~~~~~~~~~^~~~~~~~
> 1 warning generated.
>
> Did you mean to dereference it or should that print statement just
> always show? I normally would send a patch myself but since I'm not
> familiar with this code, I'd rather not shoot in the dark :) especially
> since it's for a trivial logging statement.

Fixed by fed85691b408 ("drm/i915: Fix the static code analysis warning
in debugfs"), thanks for the report & review on that one.

BR,
Jani.


--
Jani Nikula, Intel Open Source Graphics Center