2017-09-08 20:15:30

by SF Markus Elfring

Subject: [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_probe()

From: Markus Elfring <[email protected]>
Date: Fri, 8 Sep 2017 22:05:14 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/media/platform/pxa_camera.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c
index edca993c2b1f..d2a4432a98ea 100644
--- a/drivers/media/platform/pxa_camera.c
+++ b/drivers/media/platform/pxa_camera.c
@@ -2362,10 +2362,8 @@ static int pxa_camera_probe(struct platform_device *pdev)
return -ENODEV;

pcdev = devm_kzalloc(&pdev->dev, sizeof(*pcdev), GFP_KERNEL);
- if (!pcdev) {
- dev_err(&pdev->dev, "Could not allocate pcdev\n");
+ if (!pcdev)
return -ENOMEM;
- }

pcdev->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(pcdev->clk))
--
2.14.1

2017-09-09 12:42:02

by Robert Jarzmik

Subject: Re: [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_probe()

SF Markus Elfring <[email protected]> writes:

> From: Markus Elfring <[email protected]>
> Date: Fri, 8 Sep 2017 22:05:14 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
Acked-by: Robert Jarzmik <[email protected]>

Cheers.

--
Robert