2008-06-27 11:40:27

by Johannes Weiner

[permalink] [raw]
Subject: [PATCH -mmotm] fix double export of kobject_rename

Probably a merging error, line comes from the merge with -next.

Signed-off-by: Johannes Weiner <[email protected]>
---

diff --git a/lib/kobject.c b/lib/kobject.c
index 8761ef6..abfb1e2 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -540,7 +540,6 @@ out:
kfree(devpath);
return error;
}
-EXPORT_SYMBOL_GPL(kobject_rename);

/**
* kobject_del - unlink kobject from hierarchy.


2008-06-27 12:04:30

by Hugh Dickins

[permalink] [raw]
Subject: Re: [PATCH -mmotm] fix double export of kobject_rename

On Fri, 27 Jun 2008, Johannes Weiner wrote:

> Probably a merging error, line comes from the merge with -next.
>
> Signed-off-by: Johannes Weiner <[email protected]>
> ---

Please try yesterday's .DATE=2008-06-26-14-32 mmotm,
I sent Andrew a similar fix and it should be okay now.
Also includes fix to endless bad page states once you boot.

Hugh

>
> diff --git a/lib/kobject.c b/lib/kobject.c
> index 8761ef6..abfb1e2 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -540,7 +540,6 @@ out:
> kfree(devpath);
> return error;
> }
> -EXPORT_SYMBOL_GPL(kobject_rename);
>
> /**
> * kobject_del - unlink kobject from hierarchy.
> --

2008-06-27 12:35:32

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH -mmotm] fix double export of kobject_rename

Hi,

Hugh Dickins <[email protected]> writes:

> On Fri, 27 Jun 2008, Johannes Weiner wrote:
>
>> Probably a merging error, line comes from the merge with -next.
>>
>> Signed-off-by: Johannes Weiner <[email protected]>
>> ---
>
> Please try yesterday's .DATE=2008-06-26-14-32 mmotm,
> I sent Andrew a similar fix and it should be okay now.
> Also includes fix to endless bad page states once you boot.

Crap, I must have checked it out just before he updated it. Thanks,
Hugh.

Hannes