2020-12-04 23:49:07

by Michal Suchánek

[permalink] [raw]
Subject: [PATCH] powerpc: Stop exporting __clear_user which is now inlined.

Stable commit 452e2a83ea23 ("powerpc: Fix __clear_user() with KUAP
enabled") redefines __clear_user as inline function but does not remove
the export.

Fixes: 452e2a83ea23 ("powerpc: Fix __clear_user() with KUAP enabled")

Signed-off-by: Michal Suchanek <[email protected]>
---
arch/powerpc/lib/ppc_ksyms.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/lib/ppc_ksyms.c b/arch/powerpc/lib/ppc_ksyms.c
index c7f8e9586316..4b81fd96aa3e 100644
--- a/arch/powerpc/lib/ppc_ksyms.c
+++ b/arch/powerpc/lib/ppc_ksyms.c
@@ -24,7 +24,6 @@ EXPORT_SYMBOL(csum_tcpudp_magic);
#endif

EXPORT_SYMBOL(__copy_tofrom_user);
-EXPORT_SYMBOL(__clear_user);
EXPORT_SYMBOL(copy_page);

#ifdef CONFIG_PPC64
--
2.26.2


2020-12-05 11:15:29

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH] powerpc: Stop exporting __clear_user which is now inlined.

Michal Suchanek <[email protected]> writes:
> Stable commit 452e2a83ea23 ("powerpc: Fix __clear_user() with KUAP
> enabled") redefines __clear_user as inline function but does not remove
> the export.
>
> Fixes: 452e2a83ea23 ("powerpc: Fix __clear_user() with KUAP enabled")
>
> Signed-off-by: Michal Suchanek <[email protected]>
> ---
> arch/powerpc/lib/ppc_ksyms.c | 1 -
> 1 file changed, 1 deletion(-)

Acked-by: Michael Ellerman <[email protected]>

cheers

> diff --git a/arch/powerpc/lib/ppc_ksyms.c b/arch/powerpc/lib/ppc_ksyms.c
> index c7f8e9586316..4b81fd96aa3e 100644
> --- a/arch/powerpc/lib/ppc_ksyms.c
> +++ b/arch/powerpc/lib/ppc_ksyms.c
> @@ -24,7 +24,6 @@ EXPORT_SYMBOL(csum_tcpudp_magic);
> #endif
>
> EXPORT_SYMBOL(__copy_tofrom_user);
> -EXPORT_SYMBOL(__clear_user);
> EXPORT_SYMBOL(copy_page);
>
> #ifdef CONFIG_PPC64
> --
> 2.26.2

2020-12-06 09:52:16

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] powerpc: Stop exporting __clear_user which is now inlined.

On Sat, Dec 05, 2020 at 09:58:23PM +1100, Michael Ellerman wrote:
> Michal Suchanek <[email protected]> writes:
> > Stable commit 452e2a83ea23 ("powerpc: Fix __clear_user() with KUAP
> > enabled") redefines __clear_user as inline function but does not remove
> > the export.
> >
> > Fixes: 452e2a83ea23 ("powerpc: Fix __clear_user() with KUAP enabled")
> >
> > Signed-off-by: Michal Suchanek <[email protected]>
> > ---
> > arch/powerpc/lib/ppc_ksyms.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Acked-by: Michael Ellerman <[email protected]>

Now applied, thanks.

greg k-h