Since the PWM framework is switching struct pwm_state.duty_cycle's
datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
to handle a 64-bit dividend.
To: Jani Nikula <[email protected]>
Cc: Joonas Lahtinen <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Chris Wilson <[email protected]>
Cc: "Ville Syrjälä" <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Guru Das Srinagesh <[email protected]>
---
drivers/gpu/drm/i915/display/intel_panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index 276f438..81547a0 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -1920,7 +1920,7 @@ static int pwm_setup_backlight(struct intel_connector *connector,
return retval;
}
- level = DIV_ROUND_UP(pwm_get_duty_cycle(panel->backlight.pwm) * 100,
+ level = DIV_ROUND_UP_ULL(pwm_get_duty_cycle(panel->backlight.pwm) * 100,
CRC_PMIC_PWM_PERIOD_NS);
panel->backlight.level =
intel_panel_compute_brightness(connector, level);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On Tue, 21 Apr 2020, Guru Das Srinagesh <[email protected]> wrote:
> Since the PWM framework is switching struct pwm_state.duty_cycle's
> datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
> to handle a 64-bit dividend.
>
> To: Jani Nikula <[email protected]>
> Cc: Joonas Lahtinen <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Chris Wilson <[email protected]>
> Cc: "Ville Syrjälä" <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
>
Superfluous blank line.
Anyway, please preserve the existing acks and reviews [1] so people
don't have to do it again.
BR,
Jani.
[1] http://lore.kernel.org/r/[email protected]
> Signed-off-by: Guru Das Srinagesh <[email protected]>
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index 276f438..81547a0 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -1920,7 +1920,7 @@ static int pwm_setup_backlight(struct intel_connector *connector,
> return retval;
> }
>
> - level = DIV_ROUND_UP(pwm_get_duty_cycle(panel->backlight.pwm) * 100,
> + level = DIV_ROUND_UP_ULL(pwm_get_duty_cycle(panel->backlight.pwm) * 100,
> CRC_PMIC_PWM_PERIOD_NS);
> panel->backlight.level =
> intel_panel_compute_brightness(connector, level);
--
Jani Nikula, Intel Open Source Graphics Center
On Fri, Apr 24, 2020 at 09:17:58AM +0300, Jani Nikula wrote:
> On Tue, 21 Apr 2020, Guru Das Srinagesh <[email protected]> wrote:
> > Since the PWM framework is switching struct pwm_state.duty_cycle's
> > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
> > to handle a 64-bit dividend.
> >
> > To: Jani Nikula <[email protected]>
> > Cc: Joonas Lahtinen <[email protected]>
> > Cc: David Airlie <[email protected]>
> > Cc: Daniel Vetter <[email protected]>
> > Cc: Chris Wilson <[email protected]>
> > Cc: "Ville Syrjälä" <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> >
>
> Superfluous blank line.
Will remove.
>
> Anyway, please preserve the existing acks and reviews [1] so people
> don't have to do it again.
>
> BR,
> Jani.
>
> [1] http://lore.kernel.org/r/[email protected]
I dropped your Acked-by as the patch had to changed to resolve a merge
conflict when I rebased to tip. Could you please re-review this patch?
Thank you.
Guru Das.
On Fri, 24 Apr 2020, Guru Das Srinagesh <[email protected]> wrote:
> On Fri, Apr 24, 2020 at 09:17:58AM +0300, Jani Nikula wrote:
>> On Tue, 21 Apr 2020, Guru Das Srinagesh <[email protected]> wrote:
>> > Since the PWM framework is switching struct pwm_state.duty_cycle's
>> > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
>> > to handle a 64-bit dividend.
>> >
>> > To: Jani Nikula <[email protected]>
>> > Cc: Joonas Lahtinen <[email protected]>
>> > Cc: David Airlie <[email protected]>
>> > Cc: Daniel Vetter <[email protected]>
>> > Cc: Chris Wilson <[email protected]>
>> > Cc: "Ville Syrjälä" <[email protected]>
>> > Cc: [email protected]
>> > Cc: [email protected]
>> >
>>
>> Superfluous blank line.
>
> Will remove.
>
>>
>> Anyway, please preserve the existing acks and reviews [1] so people
>> don't have to do it again.
>>
>> BR,
>> Jani.
>>
>> [1] http://lore.kernel.org/r/[email protected]
>
> I dropped your Acked-by as the patch had to changed to resolve a merge
> conflict when I rebased to tip. Could you please re-review this patch?
Reviewed-by: Jani Nikula <[email protected]>
Acked-by: Jani Nikula <[email protected]>
--
Jani Nikula, Intel Open Source Graphics Center