2020-01-11 17:50:37

by Christophe Leroy

Subject: [PATCH] lib: vdso: mark __cvdso_clock_getres() as static

When __cvdso_clock_getres() became __cvdso_clock_getres_common()
and a new __cvdso_clock_getres() was added, static qualifier was
forgotten.

Fixes: 502a590a170b ("lib/vdso: Move fallback invocation to the callers")
Signed-off-by: Christophe Leroy <[email protected]>
---
lib/vdso/gettimeofday.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c
index 9ecfd3b547ba..42bd8ab955fa 100644
--- a/lib/vdso/gettimeofday.c
+++ b/lib/vdso/gettimeofday.c
@@ -221,6 +221,7 @@ int __cvdso_clock_getres_common(clockid_t clock, struct __kernel_timespec *res)
return 0;
}

+static __maybe_unused
int __cvdso_clock_getres(clockid_t clock, struct __kernel_timespec *res)
{
int ret = __cvdso_clock_getres_common(clock, res);
--
2.13.3

2020-01-11 20:04:04

by Thomas Gleixner

Subject: Re: [PATCH] lib: vdso: mark __cvdso_clock_getres() as static

Christophe Leroy <[email protected]> writes:
> When __cvdso_clock_getres() became __cvdso_clock_getres_common()
> and a new __cvdso_clock_getres() was added, static qualifier was
> forgotten.
>
> Fixes: 502a590a170b ("lib/vdso: Move fallback invocation to the callers")
> Signed-off-by: Christophe Leroy <[email protected]>

I've already queued:

https://lore.kernel.org/r/[email protected]

but thanks for caring!

Thanks,

tglx

2020-01-13 12:05:45

by Christophe Leroy

Subject: Re: [PATCH] lib: vdso: mark __cvdso_clock_getres() as static

Le 11/01/2020 à 20:59, Thomas Gleixner a écrit :
> Christophe Leroy <[email protected]> writes:
>> When __cvdso_clock_getres() became __cvdso_clock_getres_common()
>> and a new __cvdso_clock_getres() was added, static qualifier was
>> forgotten.
>>
>> Fixes: 502a590a170b ("lib/vdso: Move fallback invocation to the callers")
>> Signed-off-by: Christophe Leroy <[email protected]>
>
> I've already queued:
>
> https://lore.kernel.org/r/[email protected]
>
> but thanks for caring!
>


Is there a git tree with the latest VDSO status ?

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git?h=timers%2Fvdso
is 6 monthes old.

Christophe

2020-01-13 15:10:49

by Thomas Gleixner

Subject: Re: [PATCH] lib: vdso: mark __cvdso_clock_getres() as static

Christophe Leroy <[email protected]> writes:
> Is there a git tree with the latest VDSO status ?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git?h=timers%2Fvdso
> is 6 monthes old.

Will push a new one later today. I'll let you know.

Thanks,

tglx