2017-11-02 15:41:11

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH] usb: mtu3: fix dma_addr_t printk output again


Hi,

Arnd Bergmann <[email protected]> writes:
> The support for 36-bit addresses originally came with an incorrect
> printk format for dma addresses. Felipe changed the format string it
> while applying, but the result was still incorrect, since we now have
> to pass a pointer to the address instead of the integer value:
>
> drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_tx_gpd':
> drivers/usb/mtu3/mtu3_qmu.c:261:25: error: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=]
> drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_rx_gpd':
> drivers/usb/mtu3/mtu3_qmu.c:300:25: error: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=]
>
> This fixes the printk argument accordingly.
>
> Fixes: 1a46dfea0841 ("usb: mtu3: support 36-bit DMA address")
> Signed-off-by: Arnd Bergmann <[email protected]>

oh, so it wants a pointer afterall :-)

sorry.

Acked-by: Felipe Balbi <[email protected]>

--
balbi

From 1582965089160464666@xxx Thu Nov 02 14:32:29 +0000 2017
X-GM-THRID: 1582965089160464666
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread