Hi,
I would like to ask if I need to update anything else for this change?
Thanks,
Thang Q. Nguyen -
-----Original Message-----
From: Thang Q. Nguyen [mailto:[email protected]]
Sent: Monday, January 25, 2016 9:26 PM
To: Felipe Balbi; Greg Kroah-Hartman; [email protected];
[email protected]; [email protected];
[email protected]
Cc: Thang Nguyen; Phong Vo; Loc Ho; [email protected]
Subject: [PATCH v2 1/2] usb:dwc3: Enable support for 64-bit system
Add 64-bit DMA operation support to the USB DWC3 driver.
First attempt to set the coherent DMA mask for 64-bit DMA.
If that failed, attempt again with 32-bit DMA.
Signed-off-by: Thang Q. Nguyen <[email protected]>
---
Changes from v1:
- Remove WARN_ON if dma_mask is NULL
drivers/usb/dwc3/core.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index
de5e01f..2479c24 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -831,6 +831,21 @@ static int dwc3_probe(struct platform_device *pdev)
dwc->mem = mem;
dwc->dev = dev;
+ /* Try to set 64-bit DMA first */
+ if (!pdev->dev.dma_mask)
+ /* Platform did not initialize dma_mask */
+ ret = dma_coerce_mask_and_coherent(&pdev->dev,
+ DMA_BIT_MASK(64));
+ else
+ ret = dma_set_mask_and_coherent(&pdev->dev,
DMA_BIT_MASK(64));
+
+ /* If seting 64-bit DMA mask fails, fall back to 32-bit DMA mask
*/
+ if (ret) {
+ ret = dma_set_mask_and_coherent(&pdev->dev,
DMA_BIT_MASK(32));
+ if (ret)
+ return ret;
+ }
+
res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
if (!res) {
dev_err(dev, "missing IRQ\n");
--
2.2.0
Hi,
"Thang Q. Nguyen" <[email protected]> writes:
> [ text/plain ]
> Hi,
> I would like to ask if I need to update anything else for this change?
seems like I don't have original patch in my inbox. Please resend.
--
balbi
Thanks Felipe for your feedback.
I will re-generate patches and resend.
Regards,
Thang Q. Nguyen -
-----Original Message-----
From: Felipe Balbi [mailto:[email protected]]
Sent: Thursday, March 10, 2016 3:15 PM
To: Thang Q. Nguyen; Thang Q. Nguyen; Felipe Balbi; Greg Kroah-Hartman;
[email protected]; [email protected];
[email protected]; [email protected]
Cc: Phong Vo; Loc Ho; patches
Subject: RE: [PATCH v2 1/2] usb:dwc3: Enable support for 64-bit system
Hi,
"Thang Q. Nguyen" <[email protected]> writes:
> [ text/plain ]
> Hi,
> I would like to ask if I need to update anything else for this change?
seems like I don't have original patch in my inbox. Please resend.
--
balbi