2010-02-22 18:04:46

by OGAWA Hirofumi

Subject: [PATCH] staging/serial2002: Fix filp_open usage

Signed-off-by: OGAWA Hirofumi <[email protected]>
---

drivers/staging/comedi/drivers/serial2002.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix drivers/staging/comedi/drivers/serial2002.c
--- linux-2.6/drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix 2010-02-22 23:22:27.000000000 +0900
+++ linux-2.6-hirofumi/drivers/staging/comedi/drivers/serial2002.c 2010-02-22 23:22:27.000000000 +0900
@@ -397,7 +397,7 @@ static void serial_2002_open(struct come
char port[20];

sprintf(port, "/dev/ttyS%d", devpriv->port);
- devpriv->tty = filp_open(port, 0, O_RDWR);
+ devpriv->tty = filp_open(port, O_RDWR, 0);
if (IS_ERR(devpriv->tty)) {
printk("serial_2002: file open error = %ld\n",
PTR_ERR(devpriv->tty));
_

--
OGAWA Hirofumi <[email protected]>

2010-02-24 03:36:26

by Greg KH

Subject: Re: [PATCH] staging/serial2002: Fix filp_open usage

On Tue, Feb 23, 2010 at 03:04:42AM +0900, OGAWA Hirofumi wrote:
>
> Signed-off-by: OGAWA Hirofumi <[email protected]>
> ---
>
> drivers/staging/comedi/drivers/serial2002.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix drivers/staging/comedi/drivers/serial2002.c
> --- linux-2.6/drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix 2010-02-22 23:22:27.000000000 +0900
> +++ linux-2.6-hirofumi/drivers/staging/comedi/drivers/serial2002.c 2010-02-22 23:22:27.000000000 +0900
> @@ -397,7 +397,7 @@ static void serial_2002_open(struct come
> char port[20];
>
> sprintf(port, "/dev/ttyS%d", devpriv->port);
> - devpriv->tty = filp_open(port, 0, O_RDWR);
> + devpriv->tty = filp_open(port, O_RDWR, 0);

Oh wow that code is scary :)

I'll queue this up and remember to nuke the whole thing soon...

thanks,

greg k-h