2023-02-26 05:40:18

by Randy Dunlap

Subject: [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it

REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.

Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.

Therefore, change the use of "depends on REGMAP" to "select REGMAP".

Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using regmap")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Michael Walle <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: [email protected]
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -100,7 +100,7 @@ config GPIO_GENERIC
tristate

config GPIO_REGMAP
- depends on REGMAP
+ select REGMAP
tristate

# put drivers in the right section, in alphabetical order

2023-02-26 18:06:12

by Michael Walle

Subject: Re: [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it

Am 2023-02-26 06:39, schrieb Randy Dunlap:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using
> regmap")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Michael Walle <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Cc: [email protected]

Acked-by: Michael Walle <[email protected]>

Thanks,
-michael

2023-03-06 10:18:26

by Bartosz Golaszewski

Subject: Re: [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it

On Sun, Feb 26, 2023 at 6:40 AM Randy Dunlap <[email protected]> wrote:
>
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using regmap")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Michael Walle <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Cc: [email protected]
> ---
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -100,7 +100,7 @@ config GPIO_GENERIC
> tristate
>
> config GPIO_REGMAP
> - depends on REGMAP
> + select REGMAP
> tristate
>
> # put drivers in the right section, in alphabetical order

Queued for fixes, thanks!

Bart