2020-05-07 15:05:11

by Akash Asthana

Subject: [PATCH V6 3/3] dt-bindings: serial: Add binding for UART pin swap

Add documentation to support RX-TX & CTS-RTS GPIO pin swap in HW.

Signed-off-by: Akash Asthana <[email protected]>
---
Documentation/devicetree/bindings/serial/serial.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
index 53204d9..e657dd6 100644
--- a/Documentation/devicetree/bindings/serial/serial.yaml
+++ b/Documentation/devicetree/bindings/serial/serial.yaml
@@ -67,6 +67,12 @@ properties:
(wired and enabled by pinmux configuration). This depends on both the
UART hardware and the board wiring.

+ rx-tx-swap:
+ description: RX and TX pins are swapped.
+
+ cts-rts-swap:
+ description: CTS and RTS pins are swapped.
+
if:
required:
- uart-has-rtscts
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project

2020-05-14 01:55:12

by Stephen Boyd

Subject: Re: [PATCH V6 3/3] dt-bindings: serial: Add binding for UART pin swap

Quoting Akash Asthana (2020-05-07 08:00:47)
> Add documentation to support RX-TX & CTS-RTS GPIO pin swap in HW.
>
> Signed-off-by: Akash Asthana <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2020-05-15 03:06:14

by Rob Herring

Subject: Re: [PATCH V6 3/3] dt-bindings: serial: Add binding for UART pin swap

On Thu, May 07, 2020 at 08:30:47PM +0530, Akash Asthana wrote:
> Add documentation to support RX-TX & CTS-RTS GPIO pin swap in HW.
>
> Signed-off-by: Akash Asthana <[email protected]>
> ---
> Documentation/devicetree/bindings/serial/serial.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
> index 53204d9..e657dd6 100644
> --- a/Documentation/devicetree/bindings/serial/serial.yaml
> +++ b/Documentation/devicetree/bindings/serial/serial.yaml
> @@ -67,6 +67,12 @@ properties:
> (wired and enabled by pinmux configuration). This depends on both the
> UART hardware and the board wiring.
>
> + rx-tx-swap:
> + description: RX and TX pins are swapped.
> +
> + cts-rts-swap:
> + description: CTS and RTS pins are swapped.

Need 'type: boolean' on both of these.

> +
> if:
> required:
> - uart-has-rtscts
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project

2020-05-18 13:21:14

by Akash Asthana

Subject: Re: [PATCH V6 3/3] dt-bindings: serial: Add binding for UART pin swap

Hi Rob,

On 5/15/2020 8:31 AM, Rob Herring wrote:
> On Thu, May 07, 2020 at 08:30:47PM +0530, Akash Asthana wrote:
>> Add documentation to support RX-TX & CTS-RTS GPIO pin swap in HW.
>>
>> Signed-off-by: Akash Asthana <[email protected]>
>> ---
>> Documentation/devicetree/bindings/serial/serial.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
>> index 53204d9..e657dd6 100644
>> --- a/Documentation/devicetree/bindings/serial/serial.yaml
>> +++ b/Documentation/devicetree/bindings/serial/serial.yaml
>> @@ -67,6 +67,12 @@ properties:
>> (wired and enabled by pinmux configuration). This depends on both the
>> UART hardware and the board wiring.
>>
>> + rx-tx-swap:
>> + description: RX and TX pins are swapped.
>> +
>> + cts-rts-swap:
>> + description: CTS and RTS pins are swapped.
> Need 'type: boolean' on both of these.

okay, will correct in next version

Regards,

Akash

>
>> +
>> if:
>> required:
>> - uart-has-rtscts
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project