2023-01-30 19:07:48

by Rafael J. Wysocki

Subject: [PATCH v1 4/8] thermal: intel: intel_pch: Eliminate device operations object

From: Rafael J. Wysocki <[email protected]>

The same device operations object is pointed to by all of the board
configurations in the driver, so effectively the same operations
callbacks are used by all of them which only adds overhead (that can
be significant due to retpolines) for no real purpose.

For this reason, drop the device operations object and replace the
respective callback invocations by direct calls to the specific
functions that were previously pointed to by callback pointers.

No intentional change in behavior.

Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/thermal/intel/intel_pch_thermal.c | 33 +++---------------------------
1 file changed, 4 insertions(+), 29 deletions(-)

Index: linux-pm/drivers/thermal/intel/intel_pch_thermal.c
===================================================================
--- linux-pm.orig/drivers/thermal/intel/intel_pch_thermal.c
+++ linux-pm/drivers/thermal/intel/intel_pch_thermal.c
@@ -82,7 +82,6 @@ static char driver_name[] = "Intel PCH t

struct pch_thermal_device {
void __iomem *hw_base;
- const struct pch_dev_ops *ops;
struct pci_dev *pdev;
struct thermal_zone_device *tzd;
struct thermal_trip trips[PCH_MAX_TRIPS];
@@ -251,25 +250,11 @@ static int pch_resume(struct pch_thermal
return 0;
}

-struct pch_dev_ops {
- int (*hw_init)(struct pch_thermal_device *ptd);
- int (*get_temp)(struct pch_thermal_device *ptd);
- int (*suspend)(struct pch_thermal_device *ptd);
- int (*resume)(struct pch_thermal_device *ptd);
-};
-
-static const struct pch_dev_ops pch_dev_ops = {
- .hw_init = pch_hw_init,
- .get_temp = pch_get_temp,
- .suspend = pch_suspend,
- .resume = pch_resume,
-};
-
static int pch_thermal_get_temp(struct thermal_zone_device *tzd, int *temp)
{
struct pch_thermal_device *ptd = tzd->devdata;

- *temp = ptd->ops->get_temp(ptd);
+ *temp = pch_get_temp(ptd);
return 0;
}

@@ -295,35 +280,27 @@ enum board_ids {

static const struct board_info {
const char *name;
- const struct pch_dev_ops *ops;
} board_info[] = {
[board_hsw] = {
.name = "pch_haswell",
- .ops = &pch_dev_ops,
},
[board_wpt] = {
.name = "pch_wildcat_point",
- .ops = &pch_dev_ops,
},
[board_skl] = {
.name = "pch_skylake",
- .ops = &pch_dev_ops,
},
[board_cnl] = {
.name = "pch_cannonlake",
- .ops = &pch_dev_ops,
},
[board_cml] = {
.name = "pch_cometlake",
- .ops = &pch_dev_ops,
},
[board_lwb] = {
.name = "pch_lewisburg",
- .ops = &pch_dev_ops,
},
[board_wbg] = {
.name = "pch_wellsburg",
- .ops = &pch_dev_ops,
},
};

@@ -340,8 +317,6 @@ static int intel_pch_thermal_probe(struc
if (!ptd)
return -ENOMEM;

- ptd->ops = bi->ops;
-
pci_set_drvdata(pdev, ptd);
ptd->pdev = pdev;

@@ -364,7 +339,7 @@ static int intel_pch_thermal_probe(struc
goto error_release;
}

- nr_trips = ptd->ops->hw_init(ptd);
+ nr_trips = pch_hw_init(ptd);
if (nr_trips < 0) {
err = nr_trips;
goto error_cleanup;
@@ -412,14 +387,14 @@ static int intel_pch_thermal_suspend_noi
{
struct pch_thermal_device *ptd = dev_get_drvdata(device);

- return ptd->ops->suspend(ptd);
+ return pch_suspend(ptd);
}

static int intel_pch_thermal_resume(struct device *device)
{
struct pch_thermal_device *ptd = dev_get_drvdata(device);

- return ptd->ops->resume(ptd);
+ return pch_resume(ptd);
}

static const struct pci_device_id intel_pch_thermal_id[] = {

2023-01-31 14:57:58

by Daniel Lezcano

Subject: Re: [PATCH v1 4/8] thermal: intel: intel_pch: Eliminate device operations object

On 30/01/2023 20:02, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> The same device operations object is pointed to by all of the board
> configurations in the driver, so effectively the same operations
> callbacks are used by all of them which only adds overhead (that can
> be significant due to retpolines) for no real purpose.
>
> For this reason, drop the device operations object and replace the
> respective callback invocations by direct calls to the specific
> functions that were previously pointed to by callback pointers.
>
> No intentional change in behavior.
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> ---

Acked-by: Daniel Lezcano <[email protected]>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog