2019-11-15 01:08:21

by Shile Zhang

[permalink] [raw]
Subject: Re: [PATCH] mm/vmalloc: Fix regression caused by needless vmalloc_sync_all()



On 2019/11/15 01:12, Joerg Roedel wrote:
> On Wed, Nov 13, 2019 at 05:55:30PM +0800, Shile Zhang wrote:
>> +#if defined(CONFIG_X86_32) && defined(CONFIG_X86_PAE)
>> /*
>> * First make sure the mappings are removed from all page-tables
>> * before they are freed.
>> + *
>> + * This is only needed on x86-32 with !SHARED_KERNEL_PMD, which is
>> + * the case on a PAE kernel with PTI enabled.
>> */
>> - vmalloc_sync_all();
>> + if (!SHARED_KERNEL_PMD && boot_cpu_has(X86_FEATURE_PTI))
>> + vmalloc_sync_all();
>> +#endif
> I already submitted another fix for this quite some time ago:
>
> https://lore.kernel.org/lkml/[email protected]/
>
> Regards,
>
> Joerg
Oh, sorry for I missed that, good job and thanks for your work!