2024-01-11 11:34:22

by XueBing Chen

Subject: [PATCH] scsi: aacraid: Clean up errors in commsup.c

Fix the following errors reported by checkpatch:

ERROR: spaces required around that '<' (ctx:VxV)
ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: XueBing Chen <[email protected]>
---
drivers/scsi/aacraid/commsup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 25cee03d7f97..865316ba3c19 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -129,7 +129,7 @@ void aac_fib_vector_assign(struct aac_dev *dev)
* fib area, the unmapped fib data and also the free list
*/

-int aac_fib_setup(struct aac_dev * dev)
+int aac_fib_setup(struct aac_dev *dev)
{
struct fib *fibptr;
struct hw_fib *hw_fib;
@@ -144,7 +144,7 @@ int aac_fib_setup(struct aac_dev * dev)
if (dev->comm_interface != AAC_COMM_MESSAGE_TYPE3)
dev->init->r7.max_io_commands = cpu_to_le32(max_cmds);
}
- if (i<0)
+ if (i < 0)
return -ENOMEM;

memset(dev->hw_fib_va, 0,
--
2.17.1

2024-01-11 17:34:05

by Bart Van Assche

Subject: Re: [PATCH] scsi: aacraid: Clean up errors in commsup.c

On 1/11/24 03:32, XueBing Chen wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: XueBing Chen <[email protected]>
> ---
> drivers/scsi/aacraid/commsup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
> index 25cee03d7f97..865316ba3c19 100644
> --- a/drivers/scsi/aacraid/commsup.c
> +++ b/drivers/scsi/aacraid/commsup.c
> @@ -129,7 +129,7 @@ void aac_fib_vector_assign(struct aac_dev *dev)
> * fib area, the unmapped fib data and also the free list
> */
>
> -int aac_fib_setup(struct aac_dev * dev)
> +int aac_fib_setup(struct aac_dev *dev)
> {
> struct fib *fibptr;
> struct hw_fib *hw_fib;
> @@ -144,7 +144,7 @@ int aac_fib_setup(struct aac_dev * dev)
> if (dev->comm_interface != AAC_COMM_MESSAGE_TYPE3)
> dev->init->r7.max_io_commands = cpu_to_le32(max_cmds);
> }
> - if (i<0)
> + if (i < 0)
> return -ENOMEM;
>
> memset(dev->hw_fib_va, 0,

checkpatch is for checking patches before these are submitted and should not
be run on code that has already been merged into the kernel tree.

Bart.