2021-01-03 22:00:27

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] lightnvm: select CONFIG_CRC32

From: Arnd Bergmann <[email protected]>

Without CRC32 support, this fails to link:

arm-linux-gnueabi-ld: drivers/lightnvm/pblk-init.o: in function `pblk_init':
pblk-init.c:(.text+0x2654): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/lightnvm/pblk-init.o: in function `pblk_exit':
pblk-init.c:(.text+0x2a7c): undefined reference to `crc32_le'

Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/lightnvm/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
index 8f39f9ba5c80..4c2ce210c123 100644
--- a/drivers/lightnvm/Kconfig
+++ b/drivers/lightnvm/Kconfig
@@ -19,6 +19,7 @@ if NVM

config NVM_PBLK
tristate "Physical Block Device Open-Channel SSD target"
+ select CRC32
help
Allows an open-channel SSD to be exposed as a block device to the
host. The target assumes the device exposes raw flash and must be
--
2.29.2


2021-01-03 22:02:25

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] lightnvm: select CONFIG_CRC32

On 1/3/21 2:43 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Without CRC32 support, this fails to link:
>
> arm-linux-gnueabi-ld: drivers/lightnvm/pblk-init.o: in function `pblk_init':
> pblk-init.c:(.text+0x2654): undefined reference to `crc32_le'
> arm-linux-gnueabi-ld: drivers/lightnvm/pblk-init.o: in function `pblk_exit':
> pblk-init.c:(.text+0x2a7c): undefined reference to `crc32_le'

Applied, thanks.

--
Jens Axboe