Hi,
Friday, July 28, 2006 2:21 PM, James Bottomley wrote:
> I'll fix it up this time, but in future could you trailing whitespace
> check your patches? (git will do this for you).
I have one clarification.
When will be these patches merged into scsi-misc tree?
I've seen them merged into -mm tree.
I have another patch to create, which tree should I against for it?
Seokmann
> -----Original Message-----
> From: James Bottomley [mailto:[email protected]]
> Sent: Friday, July 28, 2006 2:21 PM
> To: Ju, Seokmann
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; Patro, Sumant; Yang, Bo
> Subject: Re: [PATCH 1/3] scsi : megaraid_{mm,mbox}: 64-bit
> DMA capabilitychecker
>
> On Tue, 2006-07-25 at 08:44 -0600, Ju, Seokmann wrote:
> > This patch contains
> > - a fix for 64-bit DMA capability check in
> megaraid_{mm,mbox} driver.
> > - includes changes (going back to 32-bit DMA mask if 64-bit DMA mask
> > failes) suggested by James with previous patch.
> > - addition of SATA 150-4/6 as commented by Vasily Averin.
>
> Warning: trailing whitespace in lines 885,889 of
> drivers/scsi/megaraid/megaraid_mbox.c
> Warning: trailing whitespace in lines
> 13,15,16,19,21,22,26,27,29,31,33,37,39,46 of
> Documentation/scsi/ChangeLog.megaraid
>
> I'll fix it up this time, but in future could you trailing whitespace
> check your patches? (git will do this for you).
>
> Also, when you do a git workflow, the body of the email becomes the
> commit message, so things like this
>
> > This is a third patch which follows prevous two patches ([PATCH 1/3]
> > and
> > [PATCH 2/3]).
>
> while no doubt being useful to the members of linux-scsi who are
> actually unable to count aren't actually useful in commit messages.
>
> James
>
>
>
On Thu, 2006-08-10 at 08:55 -0600, Ju, Seokmann wrote:
> Hi,
> Friday, July 28, 2006 2:21 PM, James Bottomley wrote:
> > I'll fix it up this time, but in future could you trailing whitespace
> > check your patches? (git will do this for you).
> I have one clarification.
> When will be these patches merged into scsi-misc tree?
> I've seen them merged into -mm tree.
> I have another patch to create, which tree should I against for it?
This posting:
http://marc.theaimsgroup.com/?l=linux-scsi&m=115509502316547
Should hopefully answer your questions.
James