2023-03-24 13:53:47

by Tom Rix

Subject: [PATCH] b43legacy: remove unused freq_r3A_value function

clang with W=1 reports
drivers/net/wireless/broadcom/b43legacy/radio.c:1713:5: error:
unused function 'freq_r3A_value' [-Werror,-Wunused-function]
u16 freq_r3A_value(u16 frequency)
^
This function is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/net/wireless/broadcom/b43legacy/radio.c | 17 -----------------
1 file changed, 17 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43legacy/radio.c b/drivers/net/wireless/broadcom/b43legacy/radio.c
index fdf78c10a05c..8d7eb89c1628 100644
--- a/drivers/net/wireless/broadcom/b43legacy/radio.c
+++ b/drivers/net/wireless/broadcom/b43legacy/radio.c
@@ -1709,23 +1709,6 @@ u16 b43legacy_radio_init2050(struct b43legacy_wldev *dev)
return ret;
}

-static inline
-u16 freq_r3A_value(u16 frequency)
-{
- u16 value;
-
- if (frequency < 5091)
- value = 0x0040;
- else if (frequency < 5321)
- value = 0x0000;
- else if (frequency < 5806)
- value = 0x0080;
- else
- value = 0x0040;
-
- return value;
-}
-
int b43legacy_radio_selectchannel(struct b43legacy_wldev *dev,
u8 channel,
int synthetic_pu_workaround)
--
2.27.0

2023-03-24 16:55:52

by Larry Finger

Subject: Re: [PATCH] b43legacy: remove unused freq_r3A_value function

On 3/24/23 08:50, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/wireless/broadcom/b43legacy/radio.c:1713:5: error:
> unused function 'freq_r3A_value' [-Werror,-Wunused-function]
> u16 freq_r3A_value(u16 frequency)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix<[email protected]>
> ---
> drivers/net/wireless/broadcom/b43legacy/radio.c | 17 -----------------
> 1 file changed, 17 deletions(-)

Acked-by: Larry Finger <[email protected]>

Thanks,

Larry

2023-03-31 14:52:15

by Kalle Valo

Subject: Re: wifi: b43legacy: remove unused freq_r3A_value function

Tom Rix <[email protected]> wrote:

> clang with W=1 reports
> drivers/net/wireless/broadcom/b43legacy/radio.c:1713:5: error:
> unused function 'freq_r3A_value' [-Werror,-Wunused-function]
> u16 freq_r3A_value(u16 frequency)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>
> Acked-by: Larry Finger <[email protected]>

Patch applied to wireless-next.git, thanks.

4c7f8c237d32 wifi: b43legacy: remove unused freq_r3A_value function

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches