2005-04-21 15:44:09

by Zou, Nanhai

[permalink] [raw]
Subject: RE: [discuss] [Patch] X86_64 TASK_SIZE cleanup


Isn't that a
!test_thread_flag(TIF_IA32) && (flags & MAP_32BIT)
in my patch?

Zou Nan hai

> -----Original Message-----
> From: Andi Kleen [mailto:[email protected]]
> Sent: Thursday, April 21, 2005 7:51 PM
> To: Zou, Nanhai
> Cc: Andi Kleen; [email protected]; [email protected];
Siddha,
> Suresh B
> Subject: Re: [discuss] [Patch] X86_64 TASK_SIZE cleanup
>
> On Thu, Apr 21, 2005 at 01:17:40AM +0800, Zou, Nanhai wrote:
> > Hi Andi,
> > What is your comment on this patch?
>
> There is at least one wrong change in there, you have a check
> for test_thread_flag(TIF_IA32) && (flags & MAP_32BIT)
>
> and that is wrong because MAP_32BIT is used from 64bit code
>
> -Andi