2023-07-12 16:33:26

by Colin Ian King

Subject: [PATCH][next][V2] video: fbdev: kyro: make some const read-only arrays static and reduce type size

Don't populate the const read-only arrays on the stack but instead
make them static const. Use smaller types to use less storage for
the arrays. Also makes the object code a little smaller.

Signed-off-by: Colin Ian King <[email protected]>
---

V2: Use smaller int types, kudos to Helge Deller for suggesting this

---
drivers/video/fbdev/kyro/STG4000InitDevice.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/fbdev/kyro/STG4000InitDevice.c
index edfa0a04854d..79886a246638 100644
--- a/drivers/video/fbdev/kyro/STG4000InitDevice.c
+++ b/drivers/video/fbdev/kyro/STG4000InitDevice.c
@@ -83,11 +83,11 @@ volatile u32 i,count=0; \
static u32 InitSDRAMRegisters(volatile STG4000REG __iomem *pSTGReg,
u32 dwSubSysID, u32 dwRevID)
{
- u32 adwSDRAMArgCfg0[] = { 0xa0, 0x80, 0xa0, 0xa0, 0xa0 };
- u32 adwSDRAMCfg1[] = { 0x8732, 0x8732, 0xa732, 0xa732, 0x8732 };
- u32 adwSDRAMCfg2[] = { 0x87d2, 0x87d2, 0xa7d2, 0x87d2, 0xa7d2 };
- u32 adwSDRAMRsh[] = { 36, 39, 40 };
- u32 adwChipSpeed[] = { 110, 120, 125 };
+ static const u8 adwSDRAMArgCfg0[] = { 0xa0, 0x80, 0xa0, 0xa0, 0xa0 };
+ static const u16 adwSDRAMCfg1[] = { 0x8732, 0x8732, 0xa732, 0xa732, 0x8732 };
+ static const u16 adwSDRAMCfg2[] = { 0x87d2, 0x87d2, 0xa7d2, 0x87d2, 0xa7d2 };
+ static const u8 adwSDRAMRsh[] = { 36, 39, 40 };
+ static const u8 adwChipSpeed[] = { 110, 120, 125 };
u32 dwMemTypeIdx;
u32 dwChipSpeedIdx;

--
2.39.2

2023-07-20 06:05:37

by Helge Deller

Subject: Re: [PATCH][next][V2] video: fbdev: kyro: make some const read-only arrays static and reduce type size

On 7/12/23 18:11, Colin Ian King wrote:
> Don't populate the const read-only arrays on the stack but instead
> make them static const. Use smaller types to use less storage for
> the arrays. Also makes the object code a little smaller.
>
> Signed-off-by: Colin Ian King <[email protected]>

applied.

Thanks!
Helge

> ---
>
> V2: Use smaller int types, kudos to Helge Deller for suggesting this
>
> ---
> drivers/video/fbdev/kyro/STG4000InitDevice.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/fbdev/kyro/STG4000InitDevice.c
> index edfa0a04854d..79886a246638 100644
> --- a/drivers/video/fbdev/kyro/STG4000InitDevice.c
> +++ b/drivers/video/fbdev/kyro/STG4000InitDevice.c
> @@ -83,11 +83,11 @@ volatile u32 i,count=0; \
> static u32 InitSDRAMRegisters(volatile STG4000REG __iomem *pSTGReg,
> u32 dwSubSysID, u32 dwRevID)
> {
> - u32 adwSDRAMArgCfg0[] = { 0xa0, 0x80, 0xa0, 0xa0, 0xa0 };
> - u32 adwSDRAMCfg1[] = { 0x8732, 0x8732, 0xa732, 0xa732, 0x8732 };
> - u32 adwSDRAMCfg2[] = { 0x87d2, 0x87d2, 0xa7d2, 0x87d2, 0xa7d2 };
> - u32 adwSDRAMRsh[] = { 36, 39, 40 };
> - u32 adwChipSpeed[] = { 110, 120, 125 };
> + static const u8 adwSDRAMArgCfg0[] = { 0xa0, 0x80, 0xa0, 0xa0, 0xa0 };
> + static const u16 adwSDRAMCfg1[] = { 0x8732, 0x8732, 0xa732, 0xa732, 0x8732 };
> + static const u16 adwSDRAMCfg2[] = { 0x87d2, 0x87d2, 0xa7d2, 0x87d2, 0xa7d2 };
> + static const u8 adwSDRAMRsh[] = { 36, 39, 40 };
> + static const u8 adwChipSpeed[] = { 110, 120, 125 };
> u32 dwMemTypeIdx;
> u32 dwChipSpeedIdx;
>