2023-01-18 00:06:30

by Hawkins, Nick

[permalink] [raw]
Subject: [PATCH v2 0/5] ARM: Add GXP I2C Support

From: Nick Hawkins <[email protected]>

The GXP SoC supports 10 I2C engines. Each I2C engine is completely
independent and can function both as an I2C master and I2C slave. The
I2C master can operate in a multi master environment. The engines support
a scalable speed from 8kHZ to 1.5 Mhz.

---

Changes since v1:
*Removed yaml documentation of hpe,gxp-sysreg as it has been
applied to syscon.yaml
*Made i2cX a generic node name i2c in dts file
*Added status field to the dtsi and the dts for i2c bus
*Removed unnecessary size-cells and address-cells from yaml
*Removed phandle from hpe,sysreg-phandle
*Changed hpe,i2c-max-bus-freq to clock-frequency
*Removed rogue tab in structure definition
*Removed use of __iomem *base local variables as it was
unnecessary
*Switched #if IS_ENABLED() -> if (IS_ENABLED()) inside
functions
*Removed use of pr_* functions
*Removed informational prints in register and unregister
functions
*Removed print from interrupt handler
*Removed informational prints from probe function
*Switched dev_err -> dev_err_probe in probe function
*Used the respective helper for mapping the resource to
__iomem

Nick Hawkins (5):
i2c: hpe: Add GXP SoC I2C Controller
dt-bindings: i2c: Add hpe,gxp-i2c
ARM: dts: hpe: Add I2C Topology
ARM: multi_v7_defconfig: add gxp i2c module
MAINTAINERS: Add HPE GXP I2C Support

.../devicetree/bindings/i2c/hpe,gxp-i2c.yaml | 54 ++
MAINTAINERS | 2 +
arch/arm/boot/dts/hpe-bmc-dl360gen10.dts | 109 ++++
arch/arm/boot/dts/hpe-gxp.dtsi | 125 ++++
arch/arm/configs/multi_v7_defconfig | 1 +
drivers/i2c/busses/Kconfig | 7 +
drivers/i2c/busses/Makefile | 1 +
drivers/i2c/busses/i2c-gxp.c | 609 ++++++++++++++++++
8 files changed, 908 insertions(+)
create mode 100644 Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml
create mode 100644 drivers/i2c/busses/i2c-gxp.c

--
2.17.1


2023-01-19 15:34:19

by Hawkins, Nick

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] ARM: Add GXP I2C Support

> Not trying to be rude, but why have you sent this to me?

Apologies. This was in error.

Thanks,

-Nick Hawkins

2023-01-20 05:04:46

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] ARM: Add GXP I2C Support

On Tue, 17 Jan 2023, [email protected] wrote:

> From: Nick Hawkins <[email protected]>
>
> The GXP SoC supports 10 I2C engines. Each I2C engine is completely
> independent and can function both as an I2C master and I2C slave. The
> I2C master can operate in a multi master environment. The engines support
> a scalable speed from 8kHZ to 1.5 Mhz.
>
> ---
>
> Changes since v1:
> *Removed yaml documentation of hpe,gxp-sysreg as it has been
> applied to syscon.yaml
> *Made i2cX a generic node name i2c in dts file
> *Added status field to the dtsi and the dts for i2c bus
> *Removed unnecessary size-cells and address-cells from yaml
> *Removed phandle from hpe,sysreg-phandle
> *Changed hpe,i2c-max-bus-freq to clock-frequency
> *Removed rogue tab in structure definition
> *Removed use of __iomem *base local variables as it was
> unnecessary
> *Switched #if IS_ENABLED() -> if (IS_ENABLED()) inside
> functions
> *Removed use of pr_* functions
> *Removed informational prints in register and unregister
> functions
> *Removed print from interrupt handler
> *Removed informational prints from probe function
> *Switched dev_err -> dev_err_probe in probe function
> *Used the respective helper for mapping the resource to
> __iomem
>
> Nick Hawkins (5):
> i2c: hpe: Add GXP SoC I2C Controller
> dt-bindings: i2c: Add hpe,gxp-i2c
> ARM: dts: hpe: Add I2C Topology
> ARM: multi_v7_defconfig: add gxp i2c module
> MAINTAINERS: Add HPE GXP I2C Support
>
> .../devicetree/bindings/i2c/hpe,gxp-i2c.yaml | 54 ++
> MAINTAINERS | 2 +
> arch/arm/boot/dts/hpe-bmc-dl360gen10.dts | 109 ++++
> arch/arm/boot/dts/hpe-gxp.dtsi | 125 ++++
> arch/arm/configs/multi_v7_defconfig | 1 +
> drivers/i2c/busses/Kconfig | 7 +
> drivers/i2c/busses/Makefile | 1 +
> drivers/i2c/busses/i2c-gxp.c | 609 ++++++++++++++++++
> 8 files changed, 908 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml
> create mode 100644 drivers/i2c/busses/i2c-gxp.c

Not trying to be rude, but why have you sent this to me?

--
Lee Jones [李琼斯]