The async_lock is big global lock, and kfree() is not always cheap, it
will increase lock contention. it's better let kfree() outside the lock
to keep the critical area as short as possible.
Signed-off-by: Yunfeng Ye <[email protected]>
Reviewed-by: Alexander Duyck <[email protected]>
Reviewed-by: Bart Van Assche <[email protected]>
---
v2 -> v3:
- move kfree() after wake_up(&async_done)
v1 -> v2:
- update the description
- add "Reviewed-by"
kernel/async.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/async.c b/kernel/async.c
index 4f9c1d614016..d2ab75e8b1ab 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -135,14 +135,14 @@ static void async_run_entry_fn(struct work_struct *work)
list_del_init(&entry->domain_list);
list_del_init(&entry->global_list);
- /* 3) free the entry */
- kfree(entry);
atomic_dec(&entry_count);
-
spin_unlock_irqrestore(&async_lock, flags);
- /* 4) wake up any waiters */
+ /* 3) wake up any waiters */
wake_up(&async_done);
+
+ /* 4) free the entry */
+ kfree(entry);
}
/**
--
2.7.4