2024-05-02 11:05:44

by Ji Sheng Teoh

[permalink] [raw]
Subject: [PATCH v2 2/2] dt-bindings: spi: spi-cadence: Add optional reset control

Document the optional reset control to SPI.

Signed-off-by: Eng Lee Teh <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ji Sheng Teoh <[email protected]>
---
Documentation/devicetree/bindings/spi/spi-cadence.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
index d4b61b0e8301..8de96abe9da1 100644
--- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
@@ -55,6 +55,13 @@ properties:
label:
description: Descriptive name of the SPI controller.

+ resets:
+ maxItems: 1
+
+ reset-names:
+ items:
+ - const: spi
+
required:
- compatible
- reg
--
2.43.2



2024-05-02 12:22:23

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] dt-bindings: spi: spi-cadence: Add optional reset control

On 02/05/2024 12:48, Ji Sheng Teoh wrote:
> Document the optional reset control to SPI.
>
> Signed-off-by: Eng Lee Teh <[email protected]>
> Signed-off-by: Ley Foon Tan <[email protected]>
> Signed-off-by: Ji Sheng Teoh <[email protected]>

Who is the author here? What are these three SoBs expressing? Rob asked
for this last time.

Best regards,
Krzysztof


2024-05-02 12:49:04

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] dt-bindings: spi: spi-cadence: Add optional reset control

On 02/05/2024 14:45, JiSheng Teoh wrote:
>> On 02/05/2024 12:48, Ji Sheng Teoh wrote:
>>> Document the optional reset control to SPI.
>>>
>>> Signed-off-by: Eng Lee Teh <[email protected]>
>>> Signed-off-by: Ley Foon Tan <[email protected]>
>>> Signed-off-by: Ji Sheng Teoh <[email protected]>
>>
>> Who is the author here? What are these three SoBs expressing? Rob asked for this last time.
>
> First SoB was the original author, the subsequent SoB made changes to the original patch.
> If intend to only keep the author, then please take the first SoB. Sorry for the noise.

Then you miss Co-developed-by tags.

Best regards,
Krzysztof


2024-05-02 13:15:49

by Ji Sheng Teoh

[permalink] [raw]
Subject: RE: [PATCH v2 2/2] dt-bindings: spi: spi-cadence: Add optional reset control

> On 02/05/2024 14:45, JiSheng Teoh wrote:
> >> On 02/05/2024 12:48, Ji Sheng Teoh wrote:
> >>> Document the optional reset control to SPI.
> >>>
> >>> Signed-off-by: Eng Lee Teh <[email protected]>
> >>> Signed-off-by: Ley Foon Tan <[email protected]>
> >>> Signed-off-by: Ji Sheng Teoh <[email protected]>
> >>
> >> Who is the author here? What are these three SoBs expressing? Rob asked for this last time.
> >
> > First SoB was the original author, the subsequent SoB made changes to the original patch.
> > If intend to only keep the author, then please take the first SoB. Sorry for the noise.
>
> Then you miss Co-developed-by tags.

Thanks, I will fix the tags in the next revision.

2024-05-02 13:53:30

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] dt-bindings: spi: spi-cadence: Add optional reset control

On 02/05/2024 12:48, Ji Sheng Teoh wrote:
> Document the optional reset control to SPI.
>
> Signed-off-by: Eng Lee Teh <[email protected]>
> Signed-off-by: Ley Foon Tan <[email protected]>
> Signed-off-by: Ji Sheng Teoh <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof


2024-05-02 15:30:42

by Ji Sheng Teoh

[permalink] [raw]
Subject: RE: [PATCH v2 2/2] dt-bindings: spi: spi-cadence: Add optional reset control

> On 02/05/2024 12:48, Ji Sheng Teoh wrote:
> > Document the optional reset control to SPI.
> >
> > Signed-off-by: Eng Lee Teh <[email protected]>
> > Signed-off-by: Ley Foon Tan <[email protected]>
> > Signed-off-by: Ji Sheng Teoh <[email protected]>
>
> Who is the author here? What are these three SoBs expressing? Rob asked for this last time.

First SoB was the original author, the subsequent SoB made changes to the original patch.
If intend to only keep the author, then please take the first SoB. Sorry for the noise.