2023-03-21 19:10:11

by Lakshmi Yadlapati

Subject: [PATCH v3 2/5] dt-bindings: trivial-devices: Add acbel,fsg032

Add new Acbel FSG032 power supply to trivial devices.

Signed-off-by: Lakshmi Yadlapati <[email protected]>
---
Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 6f482a254a1d..6fbfa79de343 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -30,6 +30,8 @@ properties:
items:
- enum:
# SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
+ # Acbel fsg032 power supply
+ - acbel,fsg032
- ad,ad7414
# ADM9240: Complete System Hardware Monitor for uProcessor-Based Systems
- ad,adm9240
--
2.37.2

2023-03-22 07:55:54

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 2/5] dt-bindings: trivial-devices: Add acbel,fsg032

On 21/03/2023 20:09, Lakshmi Yadlapati wrote:
> Add new Acbel FSG032 power supply to trivial devices.
>
> Signed-off-by: Lakshmi Yadlapati <[email protected]>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 6f482a254a1d..6fbfa79de343 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -30,6 +30,8 @@ properties:
> items:
> - enum:
> # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
> + # Acbel fsg032 power supply
> + - acbel,fsg032

No, still wrong. Open the file and look at the lines where you put the
code. It seems you add it in random places.

Best regards,
Krzysztof

2023-03-22 11:36:46

by Lakshmi Yadlapati

Subject: RE: [PATCH v3 2/5] dt-bindings: trivial-devices: Add acbel,fsg032

On 3/22/23, 2:43 AM, "Krzysztof Kozlowski" <[email protected] <mailto:[email protected]>> wrote:


On 21/03/2023 20:09, Lakshmi Yadlapati wrote:
> Add new Acbel FSG032 power supply to trivial devices.
>
> Signed-off-by: Lakshmi Yadlapati <[email protected] <mailto:[email protected]>>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 6f482a254a1d..6fbfa79de343 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -30,6 +30,8 @@ properties:
> items:
> - enum:
> # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin
> + # Acbel fsg032 power supply
> + - acbel,fsg032


No, still wrong. Open the file and look at the lines where you put the
code. It seems you add it in random places.

I am not sure the comments above belongs to ad,ad7414?
I will move the comments. Thx


Best regards,
Krzysztof