On 12/05/2022 08:30, Qin Jian wrote:
> Add documentation to describe Sunplus SP7021 clock driver bindings.
>
> Signed-off-by: Qin Jian <[email protected]>
> ---
> Remove "Binding" from yaml title
> Rename sp-sp7021.h to sunplus,sp7021-clkc.h
Thanks.
> ---
> .../bindings/clock/sunplus,sp7021-clkc.yaml | 51 +++++++++++
> MAINTAINERS | 2 +
> .../dt-bindings/clock/sunplus,sp7021-clkc.h | 88 +++++++++++++++++++
> 3 files changed, 141 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
> create mode 100644 include/dt-bindings/clock/sunplus,sp7021-clkc.h
>
> diff --git a/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml b/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
> new file mode 100644
> index 000000000..119961a17
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/sunplus,sp7021-clkc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SP7021 SoC Clock Controller
> +
> +maintainers:
> + - Qin Jian <[email protected]>
> +
> +properties:
> + compatible:
> + const: sunplus,sp7021-clkc
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + "#clock-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - "#clock-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +
Same as in v14. Please go through the comments thoroughly so reviewers
will not waste time repeating the same twice.
Best regards,
Krzysztof
> On 12/05/2022 08:30, Qin Jian wrote:
> > Add documentation to describe Sunplus SP7021 clock driver bindings.
> >
> > Signed-off-by: Qin Jian <[email protected]>
> > ---
> > Remove "Binding" from yaml title
> > Rename sp-sp7021.h to sunplus,sp7021-clkc.h
>
> Thanks.
>
> > ---
> > .../bindings/clock/sunplus,sp7021-clkc.yaml | 51 +++++++++++
> > MAINTAINERS | 2 +
> > .../dt-bindings/clock/sunplus,sp7021-clkc.h | 88 +++++++++++++++++++
> > 3 files changed, 141 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
> > create mode 100644 include/dt-bindings/clock/sunplus,sp7021-clkc.h
> >
> > diff --git a/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
> b/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
> > new file mode 100644
> > index 000000000..119961a17
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) Sunplus Co., Ltd. 2021
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/sunplus,sp7021-clkc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sunplus SP7021 SoC Clock Controller
> > +
> > +maintainers:
> > + - Qin Jian <[email protected]>
> > +
> > +properties:
> > + compatible:
> > + const: sunplus,sp7021-clkc
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + "#clock-cells":
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - "#clock-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > +
>
> Same as in v14. Please go through the comments thoroughly so reviewers
> will not waste time repeating the same twice.
>
Sorry, I don’t understand your meaning.
Could you explain more, thanks.
On 12/05/2022 12:45, qinjian[覃健] wrote:
>>> +
>>> +examples:
>>> + - |
>>> +
>>
>> Same as in v14. Please go through the comments thoroughly so reviewers
>> will not waste time repeating the same twice.
>>
>
> Sorry, I don’t understand your meaning.
> Could you explain more, thanks.
I commented in your v14. Please apply the comment or keep discussion
running. Don't ignore my comment.
Best regards,
Krzysztof