2023-06-03 02:25:49

by John Hubbard

Subject: [PATCH v2 05/11] selftests/mm: .gitignore: add mkdirty, va_high_addr_switch

These new build products were left out of .gitignore, so add them now.

Reviewed-by: David Hildenbrand <[email protected]>
Cc: Peter Xu <[email protected]>
Signed-off-by: John Hubbard <[email protected]>
---
tools/testing/selftests/mm/.gitignore | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
index 8917455f4f51..ab215303d8e9 100644
--- a/tools/testing/selftests/mm/.gitignore
+++ b/tools/testing/selftests/mm/.gitignore
@@ -39,3 +39,5 @@ local_config.h
local_config.mk
ksm_functional_tests
mdwe_test
+mkdirty
+va_high_addr_switch
\ No newline at end of file
--
2.40.1

2023-06-05 16:15:18

by Peter Xu

Subject: Re: [PATCH v2 05/11] selftests/mm: .gitignore: add mkdirty, va_high_addr_switch

On Fri, Jun 02, 2023 at 07:15:52PM -0700, John Hubbard wrote:
> These new build products were left out of .gitignore, so add them now.
>
> Reviewed-by: David Hildenbrand <[email protected]>
> Cc: Peter Xu <[email protected]>
> Signed-off-by: John Hubbard <[email protected]>
> ---
> tools/testing/selftests/mm/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index 8917455f4f51..ab215303d8e9 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -39,3 +39,5 @@ local_config.h
> local_config.mk
> ksm_functional_tests
> mdwe_test
> +mkdirty
> +va_high_addr_switch
> \ No newline at end of file

Maybe also the new gup_longterm?

Reviewed-by: Peter Xu <[email protected]>

--
Peter Xu

2023-06-05 19:44:13

by John Hubbard

Subject: Re: [PATCH v2 05/11] selftests/mm: .gitignore: add mkdirty, va_high_addr_switch

On 6/5/23 08:53, Peter Xu wrote:
> On Fri, Jun 02, 2023 at 07:15:52PM -0700, John Hubbard wrote:
>> These new build products were left out of .gitignore, so add them now.
>>
>> Reviewed-by: David Hildenbrand <[email protected]>
>> Cc: Peter Xu <[email protected]>
>> Signed-off-by: John Hubbard <[email protected]>
>> ---
>> tools/testing/selftests/mm/.gitignore | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
>> index 8917455f4f51..ab215303d8e9 100644
>> --- a/tools/testing/selftests/mm/.gitignore
>> +++ b/tools/testing/selftests/mm/.gitignore
>> @@ -39,3 +39,5 @@ local_config.h
>> local_config.mk
>> ksm_functional_tests
>> mdwe_test
>> +mkdirty
>> +va_high_addr_switch
>> \ No newline at end of file
>
> Maybe also the new gup_longterm?
>

Yes I could add that. It might make slightly easier for Andrew because it
would preemptively avoid a minor merge conflict.

Unless David is thinking of adding it to another version of that series?

> Reviewed-by: Peter Xu <[email protected]>
>

Thanks for this (and the other) reviews!

thanks,
--
John Hubbard
NVIDIA