2019-10-16 15:28:41

by Baolin Wang

Subject: [PATCH] pinctrl: sprd: Add CM4 sleep mode support

From: Bruce Chen <[email protected]>

For the new Spreadtrum pin controller, it expands 6bits to describe the
pin sleep mode with adding one CM4_SLEEP mode, which means the pin sleep
related configuration will be loaded automatically by hardware when the
CM4 system goes into deep sleep mode.

Signed-off-by: Bruce Chen <[email protected]>
Signed-off-by: Baolin Wang <[email protected]>
---
drivers/pinctrl/sprd/pinctrl-sprd.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
index 8869843..157712ab 100644
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -41,7 +41,8 @@
#define PUBCP_SLEEP_MODE BIT(14)
#define TGLDSP_SLEEP_MODE BIT(15)
#define AGDSP_SLEEP_MODE BIT(16)
-#define SLEEP_MODE_MASK GENMASK(3, 0)
+#define CM4_SLEEP_MODE BIT(17)
+#define SLEEP_MODE_MASK GENMASK(5, 0)
#define SLEEP_MODE_SHIFT 13

#define SLEEP_INPUT BIT(1)
@@ -81,6 +82,7 @@ enum pin_sleep_mode {
PUBCP_SLEEP = BIT(1),
TGLDSP_SLEEP = BIT(2),
AGDSP_SLEEP = BIT(3),
+ CM4_SLEEP = BIT(4),
};

enum pin_func_sel {
@@ -616,6 +618,8 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id,
val |= TGLDSP_SLEEP_MODE;
if (arg & AGDSP_SLEEP)
val |= AGDSP_SLEEP_MODE;
+ if (arg & CM4_SLEEP)
+ val |= CM4_SLEEP_MODE;

mask = SLEEP_MODE_MASK;
shift = SLEEP_MODE_SHIFT;
--
1.7.9.5

2019-10-16 16:12:34

by Linus Walleij

Subject: Re: [PATCH] pinctrl: sprd: Add CM4 sleep mode support

On Wed, Oct 16, 2019 at 2:24 PM Baolin Wang <[email protected]> wrote:

> From: Bruce Chen <[email protected]>
>
> For the new Spreadtrum pin controller, it expands 6bits to describe the
> pin sleep mode with adding one CM4_SLEEP mode, which means the pin sleep
> related configuration will be loaded automatically by hardware when the
> CM4 system goes into deep sleep mode.
>
> Signed-off-by: Bruce Chen <[email protected]>
> Signed-off-by: Baolin Wang <[email protected]>

Patch applied.

Yours,
Linus Walleij