2020-07-27 07:44:23

by Hsin-Yi Wang

Subject: [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property

bus-width and non-removable is not used by the driver.
max-frequency should be spi-max-frequency for flash node.

Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
Reported-by: Nicolas Boichat <[email protected]>
Signed-off-by: Hsin-Yi Wang <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index a5a12b2599a4..01522dd10603 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -431,12 +431,11 @@ &nor_flash {
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&nor_gpio1_pins>;
- bus-width = <8>;
- max-frequency = <50000000>;
- non-removable;
+
flash@0 {
compatible = "jedec,spi-nor";
reg = <0>;
+ spi-max-frequency = <50000000>;
};
};

--
2.28.0.rc0.142.g3c755180ce-goog

2020-07-31 11:23:40

by Enric Balletbo i Serra

Subject: Re: [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property

Hi Hsin-Yi,

Thank you for your patch.

On 27/7/20 9:41, Hsin-Yi Wang wrote:
> bus-width and non-removable is not used by the driver.
> max-frequency should be spi-max-frequency for flash node.
>
> Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
> Reported-by: Nicolas Boichat <[email protected]>
> Signed-off-by: Hsin-Yi Wang <[email protected]>

Reviewed-by: Enric Balletbo i Serra <[email protected]>

> ---
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index a5a12b2599a4..01522dd10603 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -431,12 +431,11 @@ &nor_flash {
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&nor_gpio1_pins>;
> - bus-width = <8>;
> - max-frequency = <50000000>;
> - non-removable;
> +
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> + spi-max-frequency = <50000000>;
> };
> };
>
>

2020-09-16 05:27:14

by Hsin-Yi Wang

Subject: Re: [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property

On Fri, Jul 31, 2020 at 7:21 PM Enric Balletbo i Serra
<[email protected]> wrote:
>
> Hi Hsin-Yi,
>
> Thank you for your patch.
>
> On 27/7/20 9:41, Hsin-Yi Wang wrote:
> > bus-width and non-removable is not used by the driver.
> > max-frequency should be spi-max-frequency for flash node.
> >
> > Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
> > Reported-by: Nicolas Boichat <[email protected]>
> > Signed-off-by: Hsin-Yi Wang <[email protected]>
>
> Reviewed-by: Enric Balletbo i Serra <[email protected]>
>
Gentle ping.

2020-09-21 10:09:18

by Matthias Brugger

Subject: Re: [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property

On 27/07/2020 09:41, Hsin-Yi Wang wrote:
> bus-width and non-removable is not used by the driver.
> max-frequency should be spi-max-frequency for flash node.
>
> Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
> Reported-by: Nicolas Boichat <[email protected]>
> Signed-off-by: Hsin-Yi Wang <[email protected]>

Applied to v5.9-next/dts64

Thanks!

> ---
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index a5a12b2599a4..01522dd10603 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -431,12 +431,11 @@ &nor_flash {
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&nor_gpio1_pins>;
> - bus-width = <8>;
> - max-frequency = <50000000>;
> - non-removable;
> +
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> + spi-max-frequency = <50000000>;
> };
> };
>
>