2022-08-24 15:36:03

by Andy Shevchenko

Subject: [PATCH v1 1/1] platform/x86: intel_cht_int33fe: Fix comment according to the code flow

We don't use software_node_register_nodes() in the code, fix the comment.

Fixes: 140355e5db8b ("platform/x86: intel_cht_int33fe: Convert software node array to group")
Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/platform/x86/intel/chtwc_int33fe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/chtwc_int33fe.c b/drivers/platform/x86/intel/chtwc_int33fe.c
index c52ac23e2331..9448e2e67c3f 100644
--- a/drivers/platform/x86/intel/chtwc_int33fe.c
+++ b/drivers/platform/x86/intel/chtwc_int33fe.c
@@ -219,7 +219,7 @@ static int cht_int33fe_add_nodes(struct cht_int33fe_data *data)

/*
* Update node used in "usb-role-switch" property. Note that we
- * rely on software_node_register_nodes() to use the original
+ * rely on software_node_register_node_group() to use the original
* instance of properties instead of copying them.
*/
fusb302_mux_refs[0].node = mux_ref_node;
--
2.35.1

2022-08-31 14:20:40

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] platform/x86: intel_cht_int33fe: Fix comment according to the code flow

On Wed, Aug 24, 2022 at 06:21:15PM +0300, Andy Shevchenko wrote:
> We don't use software_node_register_nodes() in the code, fix the comment.

Any comments?

--
With Best Regards,
Andy Shevchenko

2022-08-31 15:40:27

by Hans de Goede

Subject: Re: [PATCH v1 1/1] platform/x86: intel_cht_int33fe: Fix comment according to the code flow

Hi,

On 8/31/22 16:16, Andy Shevchenko wrote:
> On Wed, Aug 24, 2022 at 06:21:15PM +0300, Andy Shevchenko wrote:
>> We don't use software_node_register_nodes() in the code, fix the comment.
>
> Any comments?

No, I just have a bit of a patch backlog to process,
I'm trying to process the backlog in FIFO order and
I have not gotten around to this one yet.

Regards,

Hans

2022-09-01 12:58:22

by Hans de Goede

Subject: Re: [PATCH v1 1/1] platform/x86: intel_cht_int33fe: Fix comment according to the code flow

Hi,

On 8/24/22 17:21, Andy Shevchenko wrote:
> We don't use software_node_register_nodes() in the code, fix the comment.
>
> Fixes: 140355e5db8b ("platform/x86: intel_cht_int33fe: Convert software node array to group")
> Signed-off-by: Andy Shevchenko <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> drivers/platform/x86/intel/chtwc_int33fe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/chtwc_int33fe.c b/drivers/platform/x86/intel/chtwc_int33fe.c
> index c52ac23e2331..9448e2e67c3f 100644
> --- a/drivers/platform/x86/intel/chtwc_int33fe.c
> +++ b/drivers/platform/x86/intel/chtwc_int33fe.c
> @@ -219,7 +219,7 @@ static int cht_int33fe_add_nodes(struct cht_int33fe_data *data)
>
> /*
> * Update node used in "usb-role-switch" property. Note that we
> - * rely on software_node_register_nodes() to use the original
> + * rely on software_node_register_node_group() to use the original
> * instance of properties instead of copying them.
> */
> fusb302_mux_refs[0].node = mux_ref_node;