2023-07-04 12:12:54

by Minjie Du

Subject: [PATCH v1] drivers: xilinx: Fix Judgment of the return value of the devm_ioremap_resource function

IS_ERR() fix devm_ioremap_resource function return judge.
Could you help check it out?
Thank you!

Signed-off-by: Minjie Du <[email protected]>
---
drivers/dma/xilinx/xdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
index 93ee298d5..ad5ff6335 100644
--- a/drivers/dma/xilinx/xdma.c
+++ b/drivers/dma/xilinx/xdma.c
@@ -892,7 +892,7 @@ static int xdma_probe(struct platform_device *pdev)
}

reg_base = devm_ioremap_resource(&pdev->dev, res);
- if (!reg_base) {
+ if (IS_ERR(reg_base)) {
xdma_err(xdev, "ioremap failed");
goto failed;
}
--
2.39.0

2023-07-04 12:32:33

by Michal Simek

Subject: Re: [PATCH v1] drivers: xilinx: Fix Judgment of the return value of the devm_ioremap_resource function

Start subject with:

dmaengine: xilinx: xdma:

And shorten description in subject.


On 7/4/23 14:04, Minjie Du wrote:
> IS_ERR() fix devm_ioremap_resource function return judge.
> Could you help check it out?
> Thank you!

These two lines shouldn't be the part of commit message.

Also add there.
Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")

Thanks,
Michal

2023-07-05 16:55:38

by Lizhi Hou

Subject: Re: [PATCH v1] drivers: xilinx: Fix Judgment of the return value of the devm_ioremap_resource function

Hi Minjie,

There was a patch created for this. Please see

https://lore.kernel.org/all/[email protected]/


Thanks,

Lizhi

On 7/4/23 05:04, Minjie Du wrote:
> IS_ERR() fix devm_ioremap_resource function return judge.
> Could you help check it out?
> Thank you!
>
> Signed-off-by: Minjie Du <[email protected]>
> ---
> drivers/dma/xilinx/xdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
> index 93ee298d5..ad5ff6335 100644
> --- a/drivers/dma/xilinx/xdma.c
> +++ b/drivers/dma/xilinx/xdma.c
> @@ -892,7 +892,7 @@ static int xdma_probe(struct platform_device *pdev)
> }
>
> reg_base = devm_ioremap_resource(&pdev->dev, res);
> - if (!reg_base) {
> + if (IS_ERR(reg_base)) {
> xdma_err(xdev, "ioremap failed");
> goto failed;
> }