2007-10-06 13:52:53

by Adrian McMenamin

Subject: [PATCH] Fix SH4 DMAC API

This patch fixes the DMA cascade by masking the correct bits.

Tested and working with Dreamcast PVR2 DMA. With this patch applied
the existing mainline code in arch/sh/drivers/dma/dma-sh.c works,
whereas before I was patching that to get round this problem.

Signed-off by: Adrian McMenamin <[email protected]>

diff --git a/include/asm-sh/cpu-sh4/dma.h b/include/asm-sh/cpu-sh4/dma.h
index 36e26a9..aaf71b0 100644
--- a/include/asm-sh/cpu-sh4/dma.h
+++ b/include/asm-sh/cpu-sh4/dma.h
@@ -31,7 +31,7 @@
#define TS_32 0x00000030
#define TS_64 0x00000000

-#define CHCR_TS_MASK 0x30
+#define CHCR_TS_MASK 0x70
#define CHCR_TS_SHIFT 4

#define DMAOR_COD 0x00000008

2007-10-07 20:10:50

by Paul Mundt

Subject: Re: [PATCH] Fix SH4 DMAC API

On Sat, Oct 06, 2007 at 02:52:43PM +0100, Adrian McMenamin wrote:
> This patch fixes the DMA cascade by masking the correct bits.
>
> Tested and working with Dreamcast PVR2 DMA. With this patch applied
> the existing mainline code in arch/sh/drivers/dma/dma-sh.c works,
> whereas before I was patching that to get round this problem.
>
> Signed-off by: Adrian McMenamin <[email protected]>
>
Applied, thanks.