2007-10-28 14:27:17

by Adrian McMenamin

[permalink] [raw]
Subject: [PATCH] Dreamcast AICA sound - Get rid of annoying compiler warning

This patch supresses an annoying compiler warning that the variable
err may be used uninitialised.

Signed-off by: Adrian McMenamin <[email protected]>


diff --git a/sound/sh/aica.c b/sound/sh/aica.c
index 88dc840..8861d2f 100644
--- a/sound/sh/aica.c
+++ b/sound/sh/aica.c
@@ -237,6 +237,7 @@ static int aica_dma_transfer(int channels, int buffer_size,
struct snd_card_aica *dreamcastcard;
struct snd_pcm_runtime *runtime;
unsigned long flags;
+ err = 0;
dreamcastcard = substream->pcm->private_data;
period_offset = dreamcastcard->clicks;
period_offset %= (AICA_PERIOD_NUMBER / channels);


2007-10-29 10:09:21

by Takashi Iwai

[permalink] [raw]
Subject: Re: [alsa-devel] [PATCH] Dreamcast AICA sound - Get rid of annoying compiler warning

At Sun, 28 Oct 2007 14:27:04 +0000,
Adrian McMenamin wrote:
>
> This patch supresses an annoying compiler warning that the variable
> err may be used uninitialised.
>
> Signed-off by: Adrian McMenamin <[email protected]>

Applied to ALSA tree now.

Thanks,

Takashi

>
>
> diff --git a/sound/sh/aica.c b/sound/sh/aica.c
> index 88dc840..8861d2f 100644
> --- a/sound/sh/aica.c
> +++ b/sound/sh/aica.c
> @@ -237,6 +237,7 @@ static int aica_dma_transfer(int channels, int buffer_size,
> struct snd_card_aica *dreamcastcard;
> struct snd_pcm_runtime *runtime;
> unsigned long flags;
> + err = 0;
> dreamcastcard = substream->pcm->private_data;
> period_offset = dreamcastcard->clicks;
> period_offset %= (AICA_PERIOD_NUMBER / channels);
> _______________________________________________
> Alsa-devel mailing list
> [email protected]
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>