2007-12-29 17:09:23

by Thomas Bogendoerfer

Subject: [PATCH] Fix broken ip= parsing

Commit a6c05c3d064dbb83be88cba3189beb5db9d2dfc3 breaks ip= parsing
completly, because ic_enable is never set. The patch below puts
back the way ic_enable was set before.

Signed-off-by: Thomas Bogendoerfer <[email protected]>
---

net/ipv4/ipconfig.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 420f56a..4266528 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -1440,6 +1440,7 @@ static int __init ip_auto_config_setup(char *addrs)
int num = 0;

ic_set_manually = 1;
+ ic_enable = *addrs;

if (ic_proto_name(addrs))
return 1;

2007-12-29 22:54:33

by Adrian McMenamin

Subject: Re: [PATCH] Fix broken ip= parsing

On 29/12/2007, Thomas Bogendoerfer <[email protected]> wrote:
> Commit a6c05c3d064dbb83be88cba3189beb5db9d2dfc3 breaks ip= parsing
> completly, because ic_enable is never set. The patch below puts
> back the way ic_enable was set before.
>
> Signed-off-by: Thomas Bogendoerfer <[email protected]>
> ---
>
This patch certainly fixes the problem I was having with NFS root - I
had a working setup that stopped (though at the same time as I updated
my Busybox setup so I thought this was my mistake).

Please apply.

Tested by: Adrian McMenamin <[email protected]>

2007-12-30 03:00:11

by David Miller

Subject: Re: [PATCH] Fix broken ip= parsing

From: Thomas Bogendoerfer <[email protected]>
Date: Sat, 29 Dec 2007 18:08:49 +0100 (CET)

> Commit a6c05c3d064dbb83be88cba3189beb5db9d2dfc3 breaks ip= parsing
> completly, because ic_enable is never set. The patch below puts
> back the way ic_enable was set before.
>
> Signed-off-by: Thomas Bogendoerfer <[email protected]>

I already have this exact patch in my net-2.6 tree from Simon.
Thanks.