2022-07-29 06:26:56

by Pin-yen Lin

Subject: [PATCH v5] arm64: dts: mt8173-elm: Switch to SMC watchdog

Switch to SMC watchdog because we need direct control of HW watchdog
registers from kernel. The corresponding firmware was uploaded in
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.

Signed-off-by: Pin-yen Lin <[email protected]>
---

Changes in v5:
- Remove redundant new line.

Changes in v4:
- Rename the watchdog node (smc_watchdog -> watchdog)
- Correct the patch summary (mt8173-oak -> mt8173-elm)

Changes in v3:
- Remove /delete-node/ and create a new node for SMC watchdog.

Changes in v2:
- Move the modifications to mt8173-elm.dtsi and add some comments.

arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index e21feb85d822..abe3140cfcc6 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -161,6 +161,18 @@ hdmi_connector_in: endpoint {
};
};
};
+
+ watchdog {
+ compatible = "arm,smc-wdt";
+ };
+};
+
+/*
+ * Disable the original MMIO watch dog and switch to the SMC watchdog, which
+ * operates on the same MMIO.
+ */
+&watchdog {
+ status = "disabled";
};

&mfg_async {
--
2.37.1.455.g008518b4e5-goog

2022-07-29 08:41:40

by AngeloGioacchino Del Regno

Subject: Re: [PATCH v5] arm64: dts: mt8173-elm: Switch to SMC watchdog

Il 29/07/22 07:32, Pin-yen Lin ha scritto:
> Switch to SMC watchdog because we need direct control of HW watchdog
> registers from kernel. The corresponding firmware was uploaded in
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
>
> Signed-off-by: Pin-yen Lin <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2022-10-13 04:02:45

by Pin-yen Lin

Subject: Re: [PATCH v5] arm64: dts: mt8173-elm: Switch to SMC watchdog

Friendly ping on this patch.

On Fri, Jul 29, 2022 at 4:36 PM AngeloGioacchino Del Regno
<[email protected]> wrote:
>
> Il 29/07/22 07:32, Pin-yen Lin ha scritto:
> > Switch to SMC watchdog because we need direct control of HW watchdog
> > registers from kernel. The corresponding firmware was uploaded in
> > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
> >
> > Signed-off-by: Pin-yen Lin <[email protected]>
>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2023-02-01 13:17:50

by Matthias Brugger

Subject: Re: [PATCH v5] arm64: dts: mt8173-elm: Switch to SMC watchdog

On 29/07/2022 07:32, Pin-yen Lin wrote:
> Switch to SMC watchdog because we need direct control of HW watchdog
> registers from kernel. The corresponding firmware was uploaded in
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
>
> Signed-off-by: Pin-yen Lin <[email protected]>

Applied, sorry for the delay!

Matthias

> ---
>
> Changes in v5:
> - Remove redundant new line.
>
> Changes in v4:
> - Rename the watchdog node (smc_watchdog -> watchdog)
> - Correct the patch summary (mt8173-oak -> mt8173-elm)
>
> Changes in v3:
> - Remove /delete-node/ and create a new node for SMC watchdog.
>
> Changes in v2:
> - Move the modifications to mt8173-elm.dtsi and add some comments.
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index e21feb85d822..abe3140cfcc6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -161,6 +161,18 @@ hdmi_connector_in: endpoint {
> };
> };
> };
> +
> + watchdog {
> + compatible = "arm,smc-wdt";
> + };
> +};
> +
> +/*
> + * Disable the original MMIO watch dog and switch to the SMC watchdog, which
> + * operates on the same MMIO.
> + */
> +&watchdog {
> + status = "disabled";
> };
>
> &mfg_async {