From: Drew Fustini <[email protected]>
Add Analog Devices AXI PWM generator.
Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
Signed-off-by: Drew Fustini <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Co-developed-by: Trevor Gamblin <[email protected]>
Signed-off-by: Trevor Gamblin <[email protected]>
---
v5 changes:
* Modify to list only the supported axi-pwmgen-2.00.a version
v4 changes: None (rebased, added maintainer's previous Reviewed-by)
v3 changes: None (rebased, added maintainer's previous Reviewed-by)
v2 changes:
* Address feedback for driver and device tree in v1:
* Relocate "unevaluatedProperties" in device tree binding
* Remove redundant "bindings for" in description
---
.../bindings/pwm/adi,axi-pwmgen.yaml | 48 +++++++++++++++++++
MAINTAINERS | 8 ++++
2 files changed, 56 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
new file mode 100644
index 000000000000..ec6115d3796b
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AXI PWM generator
+
+maintainers:
+ - Michael Hennerich <[email protected]>
+ - Nuno Sá <[email protected]>
+
+description:
+ The Analog Devices AXI PWM generator can generate PWM signals
+ with variable pulse width and period.
+
+ https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
+
+allOf:
+ - $ref: pwm.yaml#
+
+properties:
+ compatible:
+ const: adi,axi-pwmgen-2.00.a
+
+ reg:
+ maxItems: 1
+
+ "#pwm-cells":
+ const: 2
+
+ clocks:
+ maxItems: 1
+
+required:
+ - reg
+ - clocks
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ pwm@44b00000 {
+ compatible = "adi,axi-pwmgen-2.00.a";
+ reg = <0x44b00000 0x1000>;
+ clocks = <&spi_clk>;
+ #pwm-cells = <2>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index ebf03f5f0619..d02ece54ccf6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3465,6 +3465,14 @@ W: https://ez.analog.com/linux-software-drivers
F: Documentation/devicetree/bindings/spi/adi,axi-spi-engine.yaml
F: drivers/spi/spi-axi-spi-engine.c
+AXI PWM GENERATOR
+M: Michael Hennerich <[email protected]>
+M: Nuno Sá <[email protected]>
+L: [email protected]
+S: Supported
+W: https://ez.analog.com/linux-software-drivers
+F: Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
+
AXXIA I2C CONTROLLER
M: Krzysztof Adamski <[email protected]>
L: [email protected]
--
2.44.0
On 2024-04-24 8:58 a.m., Trevor Gamblin wrote:
> From: Drew Fustini <[email protected]>
>
> Add Analog Devices AXI PWM generator.
>
> Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
> Signed-off-by: Drew Fustini <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> Co-developed-by: Trevor Gamblin <[email protected]>
> Signed-off-by: Trevor Gamblin <[email protected]>
Note that I missed the following two acks from the v4 series when
preparing v5:
Acked-by: Michael Hennerich<[email protected]>
Acked-by: Nuno Sa<[email protected]>
Trevor
> ---
> v5 changes:
> * Modify to list only the supported axi-pwmgen-2.00.a version
>
> v4 changes: None (rebased, added maintainer's previous Reviewed-by)
> v3 changes: None (rebased, added maintainer's previous Reviewed-by)
>
> v2 changes:
> * Address feedback for driver and device tree in v1:
> * Relocate "unevaluatedProperties" in device tree binding
> * Remove redundant "bindings for" in description
>
> ---
> .../bindings/pwm/adi,axi-pwmgen.yaml | 48 +++++++++++++++++++
> MAINTAINERS | 8 ++++
> 2 files changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
>
> diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> new file mode 100644
> index 000000000000..ec6115d3796b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AXI PWM generator
> +
> +maintainers:
> + - Michael Hennerich <[email protected]>
> + - Nuno Sá <[email protected]>
> +
> +description:
> + The Analog Devices AXI PWM generator can generate PWM signals
> + with variable pulse width and period.
> +
> + https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
> +
> +allOf:
> + - $ref: pwm.yaml#
> +
> +properties:
> + compatible:
> + const: adi,axi-pwmgen-2.00.a
> +
> + reg:
> + maxItems: 1
> +
> + "#pwm-cells":
> + const: 2
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - reg
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + pwm@44b00000 {
> + compatible = "adi,axi-pwmgen-2.00.a";
> + reg = <0x44b00000 0x1000>;
> + clocks = <&spi_clk>;
> + #pwm-cells = <2>;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ebf03f5f0619..d02ece54ccf6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3465,6 +3465,14 @@ W: https://ez.analog.com/linux-software-drivers
> F: Documentation/devicetree/bindings/spi/adi,axi-spi-engine.yaml
> F: drivers/spi/spi-axi-spi-engine.c
>
> +AXI PWM GENERATOR
> +M: Michael Hennerich <[email protected]>
> +M: Nuno Sá <[email protected]>
> +L: [email protected]
> +S: Supported
> +W: https://ez.analog.com/linux-software-drivers
> +F: Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> +
> AXXIA I2C CONTROLLER
> M: Krzysztof Adamski <[email protected]>
> L: [email protected]
On 26/04/2024 22:11, Trevor Gamblin wrote:
>
> On 2024-04-24 8:58 a.m., Trevor Gamblin wrote:
>> From: Drew Fustini <[email protected]>
>>
>> Add Analog Devices AXI PWM generator.
>>
>> Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
>> Signed-off-by: Drew Fustini <[email protected]>
>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>> Co-developed-by: Trevor Gamblin <[email protected]>
>> Signed-off-by: Trevor Gamblin <[email protected]>
> Note that I missed the following two acks from the v4 series when
> preparing v5:
>
> Acked-by: Michael Hennerich<[email protected]>
> Acked-by: Nuno Sa<[email protected]>
You cannot add other people's tags that way. By default b4 ignores it.
Also, don't modify the tags...
Best regards,
Krzysztof
Hello Krzysztof,
On Mon, Apr 29, 2024 at 08:23:19AM +0200, Krzysztof Kozlowski wrote:
> On 26/04/2024 22:11, Trevor Gamblin wrote:
> >
> > On 2024-04-24 8:58 a.m., Trevor Gamblin wrote:
> >> From: Drew Fustini <[email protected]>
> >>
> >> Add Analog Devices AXI PWM generator.
> >>
> >> Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
> >> Signed-off-by: Drew Fustini <[email protected]>
> >> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> >> Co-developed-by: Trevor Gamblin <[email protected]>
> >> Signed-off-by: Trevor Gamblin <[email protected]>
> > Note that I missed the following two acks from the v4 series when
> > preparing v5:
> >
> > Acked-by: Michael Hennerich<[email protected]>
> > Acked-by: Nuno Sa<[email protected]>
>
> You cannot add other people's tags that way. By default b4 ignores it.
I'm aware that I have to pay attention to that detail (i.e. using b4 am
-S). Full disclosure: I asked off-list if Trevor missed to add these
Acks and requested to add them this way if yes.
> Also, don't modify the tags...
you mean the missing space between name and email address? I can fix
that up when (and if) I apply the patches.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |