2009-01-12 22:05:35

by Mike Travis

[permalink] [raw]
Subject: [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's.


Impact: cleanup, use new cpumask API.

Minor cleanup to use the new affinity and pending_mask cpumask_var_t's
in irq_desc:

alpha irq: update alpha for new irq_desc
arm irq: update arm for new irq_desc
blackfin irq: update blackfin for new irq_desc
ia64 irq: update ia64 for new irq_desc
mips irq: update mips for new irq_desc
parisc irq: update parisc for new irq_desc
powerpc irq: update powerpc for new irq_desc
arm irq: update arm for new irq_desc

Ingo - should I push these to tip/cpus4096 via the cpus4096-for-ingo tree
since that has the relevant changes to irq_desc? Or by some other means?

Based on tip/cpus4096: v2.6.29-rc1-19-g92296c6

[I'm setting up the cross-compile toolchain and will verify (as much as I
can) that the above builds correctly.]

Signed-off-by: Mike Travis <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Bryan Wu <[email protected]>
Cc: David S. Miller <[email protected]>
Cc: Grant Grundler <[email protected]>
Cc: Kyle McMartin <[email protected]>
Cc: Matthew Wilcox <[email protected]>
Cc: Ralf Baechle <[email protected]>
Cc: Richard Henderson <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>

--


2009-01-12 22:09:38

by Mike Frysinger

[permalink] [raw]
Subject: Re: [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's.

On Mon, Jan 12, 2009 at 17:05, Mike Travis wrote:
> Cc: Bryan Wu <[email protected]>

Blackfin CC should be more [email protected]
-mike

2009-01-12 22:21:29

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's.


* Mike Travis <[email protected]> wrote:

> Impact: cleanup, use new cpumask API.
>
> Minor cleanup to use the new affinity and pending_mask cpumask_var_t's
> in irq_desc:
>
> alpha irq: update alpha for new irq_desc
> arm irq: update arm for new irq_desc
> blackfin irq: update blackfin for new irq_desc
> ia64 irq: update ia64 for new irq_desc
> mips irq: update mips for new irq_desc
> parisc irq: update parisc for new irq_desc
> powerpc irq: update powerpc for new irq_desc
> arm irq: update arm for new irq_desc

this should all be a single patch, because the cpus4096 tree does not
build on these arhitectures right now.

in fact, i think i'll rebase the whole lineup (so no need to resend - i'll
squash these fixes together), because this is how it looks like right now:

28e0886: xen: fix too early kmalloc call
92296c6: cpumask, irq: non-x86 build failures
542d865: kstat: modify kstat_irqs_legacy to be variable sized
9332fcc: irq: initialize nr_irqs based on nr_cpu_ids
0fa0ebb: irq: allocate irq_desc_ptrs array based on nr_irqs
e2f4d06: irq: use WARN() instead of WARN_ON().
9594949: irq: change references from NR_IRQS to nr_irqs
c7a3589: Xen: reduce memory required for cpu_evtchn_mask
d38b223: cpumask: reduce stack usage in find_lowest_rq
c90e785: cpumask: use cpumask_var_t in dcdbas.c
f9b9056: x86: reduce stack usage in init_intel_cacheinfo
a1c33bb: x86: cleanup remaining cpumask_t code in mce_amd_64.c
0e21990: SGI UV cpumask: use static temp cpumask in flush_tlb
4595f96: x86: change flush_tlb_others to take a const struct cpumask
802bf93: cpumask: fix bug in use cpumask_var_t in irq_desc
651f811: cpumask: convert other misc kernel functions
2f8975f: cpumask: convert drivers/net/sfc
f7df8ed: cpumask: convert misc driver functions
fbd59a8: cpumask: Use topology_core_cpumask()/topology_thread_cpumask()
7f7ace0: cpumask: update irq_desc to use cpumask_var_t

those architectures break with the first patch: 7f7ace0. That's bisection
breakage window of about 20 commits - too big and we want to avoid it if
we can (and we still can).

Ingo

2009-01-12 22:22:00

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's.


* Mike Travis <[email protected]> wrote:

> Ingo - should I push these to tip/cpus4096 via the cpus4096-for-ingo
> tree since that has the relevant changes to irq_desc? Or by some other
> means?

yes, please update cpus4096-for-ingo so that i can pull it from your tree.

Ingo

2009-01-12 22:49:34

by Mike Travis

[permalink] [raw]
Subject: Re: [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's.

Ingo Molnar wrote:
> * Mike Travis <[email protected]> wrote:
>
>> Ingo - should I push these to tip/cpus4096 via the cpus4096-for-ingo
>> tree since that has the relevant changes to irq_desc? Or by some other
>> means?
>
> yes, please update cpus4096-for-ingo so that i can pull it from your tree.
>
> Ingo

Ok, I will do that right now. And then you'll pull and do these other things:

> this should all be a single patch, because the cpus4096 tree does not
> build on these arhitectures right now.

> in fact, i think i'll rebase the whole lineup (so no need to resend - i'll
> squash these fixes together), because this is how it looks like right now:

???

Thanks,
Mike

2009-01-12 22:56:50

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's.


* Mike Travis <[email protected]> wrote:

> Ingo Molnar wrote:
> > * Mike Travis <[email protected]> wrote:
> >
> >> Ingo - should I push these to tip/cpus4096 via the cpus4096-for-ingo
> >> tree since that has the relevant changes to irq_desc? Or by some other
> >> means?
> >
> > yes, please update cpus4096-for-ingo so that i can pull it from your tree.
> >
> > Ingo
>
> Ok, I will do that right now. And then you'll pull and do these other things:
>
> > this should all be a single patch, because the cpus4096 tree does not
> > build on these arhitectures right now.
>
> > in fact, i think i'll rebase the whole lineup (so no need to resend - i'll
> > squash these fixes together), because this is how it looks like right now:
>
> ???

yes.

Ingo

2009-01-13 00:16:07

by Mike Travis

[permalink] [raw]
Subject: Re: [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's.

Ingo Molnar wrote:
> * Mike Travis <[email protected]> wrote:
>
>> Ingo - should I push these to tip/cpus4096 via the cpus4096-for-ingo
>> tree since that has the relevant changes to irq_desc? Or by some other
>> means?
>
> yes, please update cpus4096-for-ingo so that i can pull it from your tree.
>
> Ingo

Hi Ingo,

Here's the consolidated patches for the irq_desc cpumask changes. There was
one small test merge conflict w/tip-master in kernel/irq/handle.c that I was not
sure how to 'pre-fix' from this end.

Also, I'm still hunting down that mail about the cross build tools.

Thanks!
Mike


The following changes since commit 28e08861b9afab4168b758fb7b95aa7a4da0f668:
Christophe Saout (1):
xen: fix too early kmalloc call

are available in the git repository at:

ssh://master.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo.git master

Mike Travis (1):
irq: update all arches for new irq_desc

arch/alpha/kernel/irq.c | 2 +-
arch/arm/kernel/irq.c | 18 ++++++++++++------
arch/arm/oprofile/op_model_mpcore.c | 2 +-
arch/blackfin/kernel/irqchip.c | 5 +++++
arch/ia64/kernel/iosapic.c | 2 +-
arch/ia64/kernel/irq.c | 4 ++--
arch/ia64/kernel/msi_ia64.c | 4 ++--
arch/ia64/sn/kernel/msi_sn.c | 2 +-
arch/mips/include/asm/irq.h | 2 +-
arch/mips/kernel/irq-gic.c | 2 +-
arch/mips/kernel/smtc.c | 2 +-
arch/mips/mti-malta/malta-smtc.c | 5 +++--
arch/parisc/kernel/irq.c | 8 ++++----
arch/powerpc/kernel/irq.c | 2 +-
arch/powerpc/platforms/pseries/xics.c | 5 +++--
arch/powerpc/sysdev/mpic.c | 3 ++-
arch/sparc/kernel/irq_64.c | 5 +++--
17 files changed, 44 insertions(+), 29 deletions(-)

2009-01-13 01:21:22

by Mike Travis

[permalink] [raw]
Subject: Re: [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's.

Mike Frysinger wrote:
> On Mon, Jan 12, 2009 at 17:05, Mike Travis wrote:
>> Cc: Bryan Wu <[email protected]>
>
> Blackfin CC should be more [email protected]
> -mike

I saw that but it's flagged:

L: [email protected] (subscribers-only)

I assumed that means the list does not want unsolicited mail?

Thanks,
Mike

2009-01-13 01:26:13

by Mike Frysinger

[permalink] [raw]
Subject: Re: [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's.

On Mon, Jan 12, 2009 at 20:21, Mike Travis wrote:
> Mike Frysinger wrote:
>> On Mon, Jan 12, 2009 at 17:05, Mike Travis wrote:
>>> Cc: Bryan Wu <[email protected]>
>>
>> Blackfin CC should be more [email protected]
>
> I saw that but it's flagged:
>
> L: [email protected] (subscribers-only)
>
> I assumed that means the list does not want unsolicited mail?

no, it doesnt mean that. it's moderated due to spammers and the
original merge required the marking regardless of purpose. ive
updated the local MAINTAINERS file to remove that since all moderation
of non-subscribers is done transparently (no annoying notifications /
etc...).
-mike

2009-01-14 11:15:23

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH 0/8] irq: update all archs to use new irq_desc cpumask_var_t's.


* Mike Travis <[email protected]> wrote:

> Ingo Molnar wrote:
> > * Mike Travis <[email protected]> wrote:
> >
> >> Ingo - should I push these to tip/cpus4096 via the cpus4096-for-ingo
> >> tree since that has the relevant changes to irq_desc? Or by some other
> >> means?
> >
> > yes, please update cpus4096-for-ingo so that i can pull it from your tree.
> >
> > Ingo
>
> Hi Ingo,
>
> Here's the consolidated patches for the irq_desc cpumask changes. There was
> one small test merge conflict w/tip-master in kernel/irq/handle.c that I was not
> sure how to 'pre-fix' from this end.
>
> Also, I'm still hunting down that mail about the cross build tools.
>
> Thanks!
> Mike
>
>
> The following changes since commit 28e08861b9afab4168b758fb7b95aa7a4da0f668:
> Christophe Saout (1):
> xen: fix too early kmalloc call
>
> are available in the git repository at:
>
> ssh://master.kernel.org/pub/scm/linux/kernel/git/travis/linux-2.6-cpus4096-for-ingo.git master
>
> Mike Travis (1):
> irq: update all arches for new irq_desc
>
> arch/alpha/kernel/irq.c | 2 +-
> arch/arm/kernel/irq.c | 18 ++++++++++++------
> arch/arm/oprofile/op_model_mpcore.c | 2 +-
> arch/blackfin/kernel/irqchip.c | 5 +++++
> arch/ia64/kernel/iosapic.c | 2 +-
> arch/ia64/kernel/irq.c | 4 ++--
> arch/ia64/kernel/msi_ia64.c | 4 ++--
> arch/ia64/sn/kernel/msi_sn.c | 2 +-
> arch/mips/include/asm/irq.h | 2 +-
> arch/mips/kernel/irq-gic.c | 2 +-
> arch/mips/kernel/smtc.c | 2 +-
> arch/mips/mti-malta/malta-smtc.c | 5 +++--
> arch/parisc/kernel/irq.c | 8 ++++----
> arch/powerpc/kernel/irq.c | 2 +-
> arch/powerpc/platforms/pseries/xics.c | 5 +++--
> arch/powerpc/sysdev/mpic.c | 3 ++-
> arch/sparc/kernel/irq_64.c | 5 +++--
> 17 files changed, 44 insertions(+), 29 deletions(-)

Pulled into tip/cpus4096, thanks Mike!

Ingo