2021-04-22 05:19:10

by Randy Dunlap

Subject: [PATCH] ARC: kgdb: add 'fallthrough' to prevent a warning

Use the 'fallthrough' macro to document that this switch case
does indeed fall through to the next case.

../arch/arc/kernel/kgdb.c: In function 'kgdb_arch_handle_exception':
../arch/arc/kernel/kgdb.c:141:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
141 | if (kgdb_hex2long(&ptr, &addr))
| ^
../arch/arc/kernel/kgdb.c:144:2: note: here
144 | case 'D':
| ^~~~

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Vineet Gupta <[email protected]>
Cc: [email protected]
---
arch/arc/kernel/kgdb.c | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20210420.orig/arch/arc/kernel/kgdb.c
+++ linux-next-20210420/arch/arc/kernel/kgdb.c
@@ -140,6 +140,7 @@ int kgdb_arch_handle_exception(int e_vec
ptr = &remcomInBuffer[1];
if (kgdb_hex2long(&ptr, &addr))
regs->ret = addr;
+ fallthrough;

case 'D':
case 'k':

2021-04-22 15:16:34

by Vineet Gupta

Subject: Re: [PATCH] ARC: kgdb: add 'fallthrough' to prevent a warning

On 4/21/21 10:16 PM, Randy Dunlap wrote:
> Use the 'fallthrough' macro to document that this switch case
> does indeed fall through to the next case.
>
> ../arch/arc/kernel/kgdb.c: In function 'kgdb_arch_handle_exception':
> ../arch/arc/kernel/kgdb.c:141:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 141 | if (kgdb_hex2long(&ptr, &addr))
> | ^
> ../arch/arc/kernel/kgdb.c:144:2: note: here
> 144 | case 'D':
> | ^~~~
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Vineet Gupta <[email protected]>
> Cc: [email protected]

Thx for the fix Randy. Added to for-curr !

-Vineet

> ---
> arch/arc/kernel/kgdb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210420.orig/arch/arc/kernel/kgdb.c
> +++ linux-next-20210420/arch/arc/kernel/kgdb.c
> @@ -140,6 +140,7 @@ int kgdb_arch_handle_exception(int e_vec
> ptr = &remcomInBuffer[1];
> if (kgdb_hex2long(&ptr, &addr))
> regs->ret = addr;
> + fallthrough;
>
> case 'D':
> case 'k':