2023-01-27 12:00:00

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 01/11] ARM: dts: qcom-sdx55: align RPMh regulator nodes with bindings

Device node names should be generic and bindings expect certain pattern
for RPMh regulator nodes.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

See:
https://lore.kernel.org/all/[email protected]/
---
arch/arm/boot/dts/qcom-sdx55-mtp.dts | 2 +-
arch/arm/boot/dts/qcom-sdx55-t55.dts | 2 +-
arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
index 6f8909731faf..7e97ad5803d8 100644
--- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
@@ -75,7 +75,7 @@ vreg_s7e_mx_0p752: pmx55-s7e {
};

&apps_rsc {
- pmx55-rpmh-regulators {
+ regulators-0 {
compatible = "qcom,pmx55-rpmh-regulators";
qcom,pmic-id = "e";

diff --git a/arch/arm/boot/dts/qcom-sdx55-t55.dts b/arch/arm/boot/dts/qcom-sdx55-t55.dts
index ccf2b8b42b16..d5343bb0daee 100644
--- a/arch/arm/boot/dts/qcom-sdx55-t55.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-t55.dts
@@ -98,7 +98,7 @@ vreg_vddpx_2: vddpx-2 {
};

&apps_rsc {
- pmx55-rpmh-regulators {
+ regulators-0 {
compatible = "qcom,pmx55-rpmh-regulators";
qcom,pmic-id = "e";

diff --git a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
index db7b3d5b0bd0..ad74ecc2a196 100644
--- a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
+++ b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
@@ -98,7 +98,7 @@ vreg_vddpx_2: vddpx-2 {
};

&apps_rsc {
- pmx55-rpmh-regulators {
+ regulators-0 {
compatible = "qcom,pmx55-rpmh-regulators";
qcom,pmic-id = "e";

--
2.34.1



2023-01-27 12:04:19

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 08/11] arm64: dts: qcom: sm8150: align RPMh regulator nodes with bindings

Device node names should be generic and bindings expect certain pattern
for RPMh regulator nodes.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 6 +++---
arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts | 6 +++---
arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 6 +++---
arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi | 4 ++--
5 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
index eafdfbbf40b9..459384ec8f23 100644
--- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
@@ -72,7 +72,7 @@ queue0 {
};

&apps_rsc {
- pmm8155au-1-rpmh-regulators {
+ regulators-0 {
compatible = "qcom,pmm8155au-rpmh-regulators";
qcom,pmic-id = "a";

@@ -201,7 +201,7 @@ vreg_l17a_2p96: ldo17 {
};
};

- pmm8155au-2-rpmh-regulators {
+ regulators-1 {
compatible = "qcom,pmm8155au-rpmh-regulators";
qcom,pmic-id = "c";

diff --git a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
index 3331ee957d64..8f014a232526 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
@@ -56,7 +56,7 @@ key-vol-up {
};

&apps_rsc {
- pm8150-rpmh-regulators {
+ regulators-0 {
compatible = "qcom,pm8150-rpmh-regulators";
qcom,pmic-id = "a";

@@ -211,7 +211,7 @@ vreg_l17a_3p0: ldo17 {
};
};

- pm8150l-rpmh-regulators {
+ regulators-1 {
compatible = "qcom,pm8150l-rpmh-regulators";
qcom,pmic-id = "c";

@@ -324,7 +324,7 @@ vreg_l11c_3p3: ldo11 {
};
};

- pm8009-rpmh-regulators {
+ regulators-2 {
compatible = "qcom,pm8009-rpmh-regulators";
qcom,pmic-id = "f";

diff --git a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
index 5397fba9417b..69024f7c7f10 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
@@ -61,7 +61,7 @@ key-vol-up {
};

&apps_rsc {
- pm8150-rpmh-regulators {
+ regulators-0 {
compatible = "qcom,pm8150-rpmh-regulators";
qcom,pmic-id = "a";

@@ -216,7 +216,7 @@ vreg_l17a_3p0: ldo17 {
};
};

- pm8150l-rpmh-regulators {
+ regulators-1 {
compatible = "qcom,pm8150l-rpmh-regulators";
qcom,pmic-id = "c";

@@ -329,7 +329,7 @@ vreg_l11c_3p3: ldo11 {
};
};

- pm8009-rpmh-regulators {
+ regulators-2 {
compatible = "qcom,pm8009-rpmh-regulators";
qcom,pmic-id = "f";

diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
index 46b5cf9a1192..eff995a07ab7 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
@@ -51,7 +51,7 @@ vreg_s4a_1p8: pm8150-s4 {
};

&apps_rsc {
- pm8150-rpmh-regulators {
+ regulators-0 {
compatible = "qcom,pm8150-rpmh-regulators";
qcom,pmic-id = "a";

@@ -206,7 +206,7 @@ vreg_l17a_3p0: ldo17 {
};
};

- pm8150l-rpmh-regulators {
+ regulators-1 {
compatible = "qcom,pm8150l-rpmh-regulators";
qcom,pmic-id = "c";

@@ -319,7 +319,7 @@ vreg_l11c_3p3: ldo11 {
};
};

- pm8009-rpmh-regulators {
+ regulators-2 {
compatible = "qcom,pm8009-rpmh-regulators";
qcom,pmic-id = "f";

diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
index 64602748c657..ff77cc3c879a 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
@@ -173,7 +173,7 @@ &adsp_mem {
};

&apps_rsc {
- pm8150-rpmh-regulators {
+ regulators-0 {
compatible = "qcom,pm8150-rpmh-regulators";
qcom,pmic-id = "a";

@@ -306,7 +306,7 @@ vreg_l18a_0p8: ldo18 {
};
};

- pm8150l-rpmh-regulators {
+ regulators-1 {
compatible = "qcom,pm8150l-rpmh-regulators";
qcom,pmic-id = "c";

--
2.34.1


2023-01-27 12:09:26

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 05/11] arm64: dts: qcom: sc8280xp: align RPMh regulator nodes with bindings

Device node names should be generic and bindings expect certain pattern
for RPMh regulator nodes.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 +++---
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
index 20c629172477..2f43b2fbc2a1 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
@@ -142,7 +142,7 @@ linux,cma {
};

&apps_rsc {
- pmc8280-1-rpmh-regulators {
+ regulators-0 {
compatible = "qcom,pm8350-rpmh-regulators";
qcom,pmic-id = "b";

@@ -179,7 +179,7 @@ vreg_l6b: ldo6 {
};
};

- pmc8280c-rpmh-regulators {
+ regulators-1 {
compatible = "qcom,pm8350c-rpmh-regulators";
qcom,pmic-id = "c";

@@ -208,7 +208,7 @@ vreg_l13c: ldo13 {
};
};

- pmc8280-2-rpmh-regulators {
+ regulators-2 {
compatible = "qcom,pm8350-rpmh-regulators";
qcom,pmic-id = "d";

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index b60185d9bdea..e41b630141fc 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -287,7 +287,7 @@ map1 {
};

&apps_rsc {
- pmc8280-1-rpmh-regulators {
+ regulators-0 {
compatible = "qcom,pm8350-rpmh-regulators";
qcom,pmic-id = "b";

@@ -338,7 +338,7 @@ vreg_l6b: ldo6 {
};
};

- pmc8280c-rpmh-regulators {
+ regulators-1 {
compatible = "qcom,pm8350c-rpmh-regulators";
qcom,pmic-id = "c";
vdd-bob-supply = <&vreg_vph_pwr>;
@@ -372,7 +372,7 @@ vreg_bob: bob {
};
};

- pmc8280-2-rpmh-regulators {
+ regulators-2 {
compatible = "qcom,pm8350-rpmh-regulators";
qcom,pmic-id = "d";

--
2.34.1


2023-01-27 12:10:45

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 01/11] ARM: dts: qcom-sdx55: align RPMh regulator nodes with bindings



On 27.01.2023 12:43, Krzysztof Kozlowski wrote:
> Device node names should be generic and bindings expect certain pattern
> for RPMh regulator nodes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
>
> See:
> https://lore.kernel.org/all/[email protected]/
> ---
> arch/arm/boot/dts/qcom-sdx55-mtp.dts | 2 +-
> arch/arm/boot/dts/qcom-sdx55-t55.dts | 2 +-
> arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> index 6f8909731faf..7e97ad5803d8 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> @@ -75,7 +75,7 @@ vreg_s7e_mx_0p752: pmx55-s7e {
> };
>
> &apps_rsc {
> - pmx55-rpmh-regulators {
> + regulators-0 {
> compatible = "qcom,pmx55-rpmh-regulators";
> qcom,pmic-id = "e";
>
> diff --git a/arch/arm/boot/dts/qcom-sdx55-t55.dts b/arch/arm/boot/dts/qcom-sdx55-t55.dts
> index ccf2b8b42b16..d5343bb0daee 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-t55.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-t55.dts
> @@ -98,7 +98,7 @@ vreg_vddpx_2: vddpx-2 {
> };
>
> &apps_rsc {
> - pmx55-rpmh-regulators {
> + regulators-0 {
> compatible = "qcom,pmx55-rpmh-regulators";
> qcom,pmic-id = "e";
>
> diff --git a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> index db7b3d5b0bd0..ad74ecc2a196 100644
> --- a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> +++ b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts
> @@ -98,7 +98,7 @@ vreg_vddpx_2: vddpx-2 {
> };
>
> &apps_rsc {
> - pmx55-rpmh-regulators {
> + regulators-0 {
> compatible = "qcom,pmx55-rpmh-regulators";
> qcom,pmic-id = "e";
>

2023-01-27 12:11:39

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 05/11] arm64: dts: qcom: sc8280xp: align RPMh regulator nodes with bindings



On 27.01.2023 12:43, Krzysztof Kozlowski wrote:
> Device node names should be generic and bindings expect certain pattern
> for RPMh regulator nodes.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 +++---
> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index 20c629172477..2f43b2fbc2a1 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -142,7 +142,7 @@ linux,cma {
> };
>
> &apps_rsc {
> - pmc8280-1-rpmh-regulators {
> + regulators-0 {
> compatible = "qcom,pm8350-rpmh-regulators";
> qcom,pmic-id = "b";
>
> @@ -179,7 +179,7 @@ vreg_l6b: ldo6 {
> };
> };
>
> - pmc8280c-rpmh-regulators {
> + regulators-1 {
> compatible = "qcom,pm8350c-rpmh-regulators";
> qcom,pmic-id = "c";
>
> @@ -208,7 +208,7 @@ vreg_l13c: ldo13 {
> };
> };
>
> - pmc8280-2-rpmh-regulators {
> + regulators-2 {
> compatible = "qcom,pm8350-rpmh-regulators";
> qcom,pmic-id = "d";
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index b60185d9bdea..e41b630141fc 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -287,7 +287,7 @@ map1 {
> };
>
> &apps_rsc {
> - pmc8280-1-rpmh-regulators {
> + regulators-0 {
> compatible = "qcom,pm8350-rpmh-regulators";
> qcom,pmic-id = "b";
>
> @@ -338,7 +338,7 @@ vreg_l6b: ldo6 {
> };
> };
>
> - pmc8280c-rpmh-regulators {
> + regulators-1 {
> compatible = "qcom,pm8350c-rpmh-regulators";
> qcom,pmic-id = "c";
> vdd-bob-supply = <&vreg_vph_pwr>;
> @@ -372,7 +372,7 @@ vreg_bob: bob {
> };
> };
>
> - pmc8280-2-rpmh-regulators {
> + regulators-2 {
> compatible = "qcom,pm8350-rpmh-regulators";
> qcom,pmic-id = "d";
>

2023-02-09 04:32:07

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 01/11] ARM: dts: qcom-sdx55: align RPMh regulator nodes with bindings

On Fri, 27 Jan 2023 12:43:37 +0100, Krzysztof Kozlowski wrote:
> Device node names should be generic and bindings expect certain pattern
> for RPMh regulator nodes.
>
>

Applied, thanks!

[03/11] arm64: dts: qcom: sa8295p-adp: align RPMh regulator nodes with bindings
commit: f8e749dc7193a4b727659a69f5760a6a94ffcb1e
[04/11] arm64: dts: qcom: sc7180: align RPMh regulator nodes with bindings
commit: adfb9d68e976c79e07cb64a87f58ea5f4d243a6d
[05/11] arm64: dts: qcom: sc8280xp: align RPMh regulator nodes with bindings
commit: 4275d2802b4bfbf06780be778538d0872e657dfd
[06/11] arm64: dts: qcom: sdm845: align RPMh regulator nodes with bindings
commit: 86dd19bbdea2b7d3feb69c0c39f141de30a18ec9
[07/11] arm64: dts: qcom: sm7225: align RPMh regulator nodes with bindings
commit: 45e9251bdd1118cd97061aec502a5747a1cf1bd6
[08/11] arm64: dts: qcom: sm8150: align RPMh regulator nodes with bindings
commit: 5a88bb6146b39773534b627d3431bf7d49115abd
[09/11] arm64: dts: qcom: sm8250: align RPMh regulator nodes with bindings
commit: 537f572b2f681f48e58a26bef46611f03b33681e
[10/11] arm64: dts: qcom: sm8350: align RPMh regulator nodes with bindings
commit: 0223fe2b3f46e6cfe644563ec7217d2dc7d603b6
[11/11] arm64: dts: qcom: sm8450: align RPMh regulator nodes with bindings
commit: 6216007a3bcd0deab1a5695c32a141e8a4493ad9

Best regards,
--
Bjorn Andersson <[email protected]>