2021-06-25 07:44:28

by George Liu

Subject: [PATCH v1] ARM: dts: fp5280g2: Add KCS node for LPC MCTP

Signed-off-by: George Liu <[email protected]>
---
arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
index 1752f3250e44..66c0542b2694 100644
--- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
@@ -300,6 +300,11 @@ &lpc_ctrl {
flash = <&spi1>;
};

+&kcs4 {
+ compatible = "openbmc,mctp-lpc";
+ status = "okay";
+};
+
&mac0 {
status = "okay";
pinctrl-names = "default";
--
2.30.2

2021-07-01 04:08:19

by Andrew Jeffery

Subject: Re: [PATCH v1] ARM: dts: fp5280g2: Add KCS node for LPC MCTP

Hi George,

On Fri, 25 Jun 2021, at 17:10, George Liu wrote:
> Signed-off-by: George Liu <[email protected]>
> ---
> arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> index 1752f3250e44..66c0542b2694 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> @@ -300,6 +300,11 @@ &lpc_ctrl {
> flash = <&spi1>;
> };
>
> +&kcs4 {
> + compatible = "openbmc,mctp-lpc";
> + status = "okay";
> +};

This was a gross hack that we carried for a bit, it never went or was
intended to go upstream. Please just use the standard KCS bindings.

Cheers,

Andrew