2022-11-21 10:15:37

by Tony Huang

Subject: [PATCH v12 1/2] dt-binding: mmc: Add mmc yaml file for Sunplus SP7021

Add MMC YAML file for Sunplus SP7021.

Reviewed-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Tony Huang <[email protected]>
---
Changes in v5:
- Addressed comments from Krzysztof.

Changes in v6:
- Addressed comments from Krzysztof.
- To substitute MMC for mmc. To substitute YMAL for ymal.
- Remove max-frequency.
- Fixed wrong file name.

Changes in v7:
-No change.

Changes in v8:
-No change.

Changes in v9:
-No change.

Changes in v10:
-No change.

Changes in v11:
-No change.

Changes in v12:
-No change.

.../devicetree/bindings/mmc/sunplus,mmc.yaml | 62 ++++++++++++++++++++++
MAINTAINERS | 6 +++
2 files changed, 68 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml

diff --git a/Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml b/Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml
new file mode 100644
index 0000000..50f2119
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) Sunplus Ltd. Co. 2021
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/sunplus,mmc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sunplus MMC Controller
+
+maintainers:
+ - Tony Huang <[email protected]>
+ - Li-hao Kuo <[email protected]>
+
+allOf:
+ - $ref: "mmc-controller.yaml"
+
+properties:
+ compatible:
+ enum:
+ - sunplus,sp7021-mmc
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - resets
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ mmc0: mmc@9c003b00 {
+ compatible = "sunplus,sp7021-mmc";
+ reg = <0x9c003b00 0x180>;
+ interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clkc 0x4e>;
+ resets = <&rstc 0x3e>;
+ bus-width = <8>;
+ max-frequency = <52000000>;
+ non-removable;
+ disable-wp;
+ cap-mmc-highspeed;
+ mmc-ddr-3_3v;
+ no-sdio;
+ no-sd;
+ };
+
diff --git a/MAINTAINERS b/MAINTAINERS
index 2585e7e..2d90fe6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19748,6 +19748,12 @@ W: https://sunplus.atlassian.net/wiki/spaces/doc/overview
F: Documentation/devicetree/bindings/net/sunplus,sp7021-emac.yaml
F: drivers/net/ethernet/sunplus/

+SUNPLUS MMC DRIVER
+M: Tony Huang <[email protected]>
+M: Li-hao Kuo <[email protected]>
+S: Maintained
+F: Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml
+
SUNPLUS OCOTP DRIVER
M: Vincent Shih <[email protected]>
S: Maintained
--
2.7.4

2022-11-21 10:50:57

by Krzysztof Kozlowski

Subject: Re: [PATCH v12 1/2] dt-binding: mmc: Add mmc yaml file for Sunplus SP7021

On 21/11/2022 11:06, Tony Huang wrote:
> Add MMC YAML file for Sunplus SP7021.

> +++ b/Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Ltd. Co. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/sunplus,mmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus MMC Controller
> +
> +maintainers:
> + - Tony Huang <[email protected]>
> + - Li-hao Kuo <[email protected]>
> +
> +allOf:
> + - $ref: "mmc-controller.yaml"

If there is going to be resend, drop the quotes (and keep my Reviewed-by
tag).

Best regards,
Krzysztof