2019-04-06 12:30:47

by Hariprasad Kelam

Subject: [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer

Changes passing function argument 0 to NULL to avoid below sparse
warning

CHECK drivers/xen/xen-pciback/xenbus.c
drivers/xen/xen-pciback/xenbus.c:700:51: warning: Using plain integer as
NULL pointer

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/xen/xen-pciback/xenbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index 23f7f6e..833b2d2 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -697,7 +697,7 @@ static int xen_pcibk_xenbus_probe(struct xenbus_device *dev,
/* We need to force a call to our callback here in case
* xend already configured us!
*/
- xen_pcibk_be_watch(&pdev->be_watch, NULL, 0);
+ xen_pcibk_be_watch(&pdev->be_watch, NULL, NULL);

out:
return err;
--
2.7.4

2019-04-06 19:04:45

by Mukesh Ojha

Subject: Re: [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer

On 4/6/2019 5:59 PM, Hariprasad Kelam wrote:
> Changes passing function argument 0 to NULL to avoid below sparse
> warning
>
> CHECK drivers/xen/xen-pciback/xenbus.c
> drivers/xen/xen-pciback/xenbus.c:700:51: warning: Using plain integer as
> NULL pointer
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> drivers/xen/xen-pciback/xenbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
> index 23f7f6e..833b2d2 100644
> --- a/drivers/xen/xen-pciback/xenbus.c
> +++ b/drivers/xen/xen-pciback/xenbus.c
> @@ -697,7 +697,7 @@ static int xen_pcibk_xenbus_probe(struct xenbus_device *dev,
> /* We need to force a call to our callback here in case
> * xend already configured us!
> */
> - xen_pcibk_be_watch(&pdev->be_watch, NULL, 0);
> + xen_pcibk_be_watch(&pdev->be_watch, NULL, NULL);
>
> out:
> return err;

2019-04-08 05:11:36

by Jürgen Groß

Subject: Re: [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer

On 06/04/2019 14:29, Hariprasad Kelam wrote:
> Changes passing function argument 0 to NULL to avoid below sparse
> warning
>
> CHECK drivers/xen/xen-pciback/xenbus.c
> drivers/xen/xen-pciback/xenbus.c:700:51: warning: Using plain integer as
> NULL pointer
>
> Signed-off-by: Hariprasad Kelam <[email protected]>

Reviewed-by: Juergen Gross <[email protected]>


Juergen

2019-04-25 05:52:01

by Boris Ostrovsky

Subject: Re: [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer

On 4/6/19 8:29 AM, Hariprasad Kelam wrote:
> Changes passing function argument 0 to NULL to avoid below sparse
> warning
>
> CHECK drivers/xen/xen-pciback/xenbus.c
> drivers/xen/xen-pciback/xenbus.c:700:51: warning: Using plain integer as
> NULL pointer
>
> Signed-off-by: Hariprasad Kelam <[email protected]>

Applied to for-linus-5.2